-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add Badge component and documentation #6371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: subh05sus <sahasubhadipfkk@gmail.com>
🚀 Preview for commit 81c669d at: https://67f04956af4416feddb20233--layer5.netlify.app |
@subh05sus adding it as an agenda item to the meeting minutes. |
🚀 Preview for commit 6c891f6 at: https://67f3a5d43944f52d876ef19b--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Wait for @amitamrutiya Approval.
🚀 Preview for commit d90a454 at: https://67fccbb7c95f4abf8ace25dc--layer5.netlify.app |
Hi @sudhanshutech @amitamrutiya @GARY121github 👋 Just a gentle reminder — this PR is ready for review and has been pending for a while. I’d really appreciate it if you could take a look when you get a chance. Let me know if anything needs to be addressed from my end. Thanks in advance! 🙏 |
🚀 Preview for commit d83eb5e at: https://680392873da98f25547bd12a--layer5.netlify.app |
@@ -1,4 +1,12 @@ | |||
const componentsData = [ | |||
{ | |||
id: 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add it to first, there is sort functionality already there which will sort based on alphabetical order
@@ -0,0 +1,255 @@ | |||
/* eslint-disable linebreak-style */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why need to disable eslint rule? please avoid using this and fix if there any linting issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing it out. I’ve removed the ESLint disable comment and fixed the line endings to use LF. Dont worry, removing this
Signed-off-by: Subhadip Saha <sahasubhadipfkk@gmail.com>
|
🚀 Preview for commit 6e9d16f at: https://6821b6b232fbf179f55f3db5--layer5.netlify.app |
@@ -0,0 +1,18 @@ | |||
import React, { useState } from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@subh05sus a extra block component is not required. there is already one reuse that and delete this file please.
@subh05sus any update? |
Hi! I'm currently in the middle of my semester exams. I kindly request 4–5 more days to work on the issue. I’ll get it resolved right after that. Thanks for your understanding! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@subh05sus any updates? |
Signed-off-by: subh05sus sahasubhadipfkk@gmail.com
Description
This PR introduces a new
Badge
component in the Sistent library, complete with usage documentation and examples. The component acts as a visual indicator for statuses and notifications, promoting UI consistency and reusability across Layer5 projects.The addition includes:
Badge
component and its intended use.This update improves discoverability and usability by representing the component on the Sistent Components page, helping new contributors onboard faster.
This PR fixes #5905
Checklist
Signed commits