Skip to content

Add Badge component and documentation #6371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

subh05sus
Copy link

Signed-off-by: subh05sus sahasubhadipfkk@gmail.com

Description

This PR introduces a new Badge component in the Sistent library, complete with usage documentation and examples. The component acts as a visual indicator for statuses and notifications, promoting UI consistency and reusability across Layer5 projects.

The addition includes:

  • A detailed explanation of the Badge component and its intended use.
  • Multiple code examples to demonstrate different use cases.
  • Stylistic guidelines for consistent implementation.

This update improves discoverability and usability by representing the component on the Sistent Components page, helping new contributors onboard faster.

This PR fixes #5905

Checklist

  • Component created
  • Documentation added
  • Usage examples provided

Signed commits

  • Yes, I signed my commits.

Signed-off-by: subh05sus <sahasubhadipfkk@gmail.com>
@l5io
Copy link
Contributor

l5io commented Apr 4, 2025

🚀 Preview for commit 81c669d at: https://67f04956af4416feddb20233--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@subh05sus
Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST

adding it as an agenda item to the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Apr 7, 2025

🚀 Preview for commit 6c891f6 at: https://67f3a5d43944f52d876ef19b--layer5.netlify.app

Copy link
Member

@Ajay-singh1 Ajay-singh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Wait for @amitamrutiya Approval.

@l5io
Copy link
Contributor

l5io commented Apr 14, 2025

🚀 Preview for commit d90a454 at: https://67fccbb7c95f4abf8ace25dc--layer5.netlify.app

@subh05sus
Copy link
Author

Hi @sudhanshutech @amitamrutiya @GARY121github 👋 Just a gentle reminder — this PR is ready for review and has been pending for a while. I’d really appreciate it if you could take a look when you get a chance. Let me know if anything needs to be addressed from my end. Thanks in advance! 🙏

@l5io
Copy link
Contributor

l5io commented Apr 19, 2025

🚀 Preview for commit d83eb5e at: https://680392873da98f25547bd12a--layer5.netlify.app

@@ -1,4 +1,12 @@
const componentsData = [
{
id: 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to add it to first, there is sort functionality already there which will sort based on alphabetical order

@@ -0,0 +1,255 @@
/* eslint-disable linebreak-style */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need to disable eslint rule? please avoid using this and fix if there any linting issues

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out. I’ve removed the ESLint disable comment and fixed the line endings to use LF. Dont worry, removing this

subh05sus added 2 commits May 12, 2025 14:09
Signed-off-by: Subhadip Saha <sahasubhadipfkk@gmail.com>
@subh05sus subh05sus requested a review from sudhanshutech May 12, 2025 08:40
Copy link

github-actions bot commented May 12, 2025

@l5io
Copy link
Contributor

l5io commented May 12, 2025

🚀 Preview for commit 6e9d16f at: https://6821b6b232fbf179f55f3db5--layer5.netlify.app

@@ -0,0 +1,18 @@
import React, { useState } from "react";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subh05sus a extra block component is not required. there is already one reuse that and delete this file please.

@sudhanshutech
Copy link
Member

@subh05sus any update?

@subh05sus
Copy link
Author

@subh05sus any update?

Hi! I'm currently in the middle of my semester exams. I kindly request 4–5 more days to work on the issue. I’ll get it resolved right after that. Thanks for your understanding!

Copy link

stale bot commented Jun 27, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jun 27, 2025
@vr-varad
Copy link
Contributor

@subh05sus any updates?

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sistent] Add Badge component to the sistent components page
6 participants