Skip to content

Fix : Enhance Image Viewer Usability with Standard Navigation #6379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 29, 2025
Merged

Fix : Enhance Image Viewer Usability with Standard Navigation #6379

merged 8 commits into from
Jun 29, 2025

Conversation

Jeffrin2005
Copy link
Contributor

@Jeffrin2005 Jeffrin2005 commented Apr 9, 2025 •
edited by vishalvivekm
Loading

Description

Merge Checklist

  • Prep screenshot or demo video for changelog entry, and attach it to issue.
feature2.mp4
  • Completion of QA in Mobile Devices
  • Completion of QA in Desktop Devices

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Apr 9, 2025

🚀 Preview for commit 5d7320b at: https://67f6518833bdfdce99cfc21d--layer5.netlify.app

@vr-varad
Copy link
Contributor

vr-varad commented Apr 9, 2025

@Jeffrin2005 Please don't change the formatting, rest everything looks good

@Jeffrin2005
Copy link
Contributor Author

@vr-varad Formating means - the alignment of codes , right ?

@l5io
Copy link
Contributor

l5io commented Apr 9, 2025

🚀 Preview for commit 1200994 at: https://67f66c032056d6149b0ead0a--layer5.netlify.app

@Jeffrin2005
fixed image scrolling
f9745cb 
Signed-off-by: Jeffrin Jojo <135723871+Jeffrin2005@users.noreply.github.com>
Signed-off-by: Jeffrin Jojo <jeffrinjojo1@gmail.com>
@Jeffrin2005
fix format issue
d6b2e3d 
Signed-off-by: Jeffrin Jojo <jeffrinjojo1@gmail.com>
@Jeffrin2005
fixing format2
462b86a 
Signed-off-by: Jeffrin Jojo <135723871+Jeffrin2005@users.noreply.github.com>
Signed-off-by: Jeffrin Jojo <jeffrinjojo1@gmail.com>
@Jeffrin2005
Copy link
Contributor Author

@vr-varad Fixed DCO errors.

@vr-varad
Copy link
Contributor

LGTM @Jeffrin2005
@vishalvivekm @amitamrutiya

@l5io
Copy link
Contributor

l5io commented Apr 10, 2025

🚀 Preview for commit 462b86a at: https://67f801b931f528330e505f50--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@Jeffrin2005
Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST

Add it as an agenda item to the meeting minutes, if you would :)

@l5io
Copy link
Contributor

l5io commented Apr 14, 2025

🚀 Preview for commit 513d6ca at: https://67fccb30c95f4abf8ace2400--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

Screen Shot 2025-04-14 at 16 20 35

@Jeffrin2005
responsive issue
784195d 
Signed-off-by: Jeffrin Jojo <jeffrinjojo1@gmail.com>
@Jeffrin2005
test 1
46f9cba 
Signed-off-by: Jeffrin Jojo <jeffrinjojo1@gmail.com>
@Jeffrin2005
orginal fix
3910ba6 
Signed-off-by: Jeffrin Jojo <jeffrinjojo1@gmail.com>
@l5io
Copy link
Contributor

l5io commented Apr 16, 2025

🚀 Preview for commit 3910ba6 at: https://67ff23f402d715b1102d71fb--layer5.netlify.app

@Jeffrin2005
removing square behind arrows
90bb721 
Signed-off-by: Jeffrin Jojo <jeffrinjojo1@gmail.com>
@l5io
Copy link
Contributor

l5io commented Apr 17, 2025

🚀 Preview for commit 90bb721 at: https://680133a22c08f712c7a8eb14--layer5.netlify.app

@Jeffrin2005
Copy link
Contributor Author

@vishalvivekm

fix91.mp4

Now removed the box (behind the arrows) , and also fixed the responsive issue.
Can you review this .

@Jeffrin2005
Copy link
Contributor Author

@vishalvivekm @leecalcote Can you review this PR?

@stale Stale
Copy link

stale bot commented Jun 27, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jun 27, 2025
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jun 28, 2025
@l5io
Copy link
Contributor

l5io commented Jun 28, 2025

🚀 Preview for commit 5818ce0 at: https://685fbcdaf9c1d68479d769fe--layer5.netlify.app

vishalvivekm
vishalvivekm approved these changes Jun 29, 2025
View reviewed changes
Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Jeffrin2005 the updated navigation between how it works screenshots looks much better in both desktop as well as mobile views.

@vishalvivekm vishalvivekm merged commit 81bef11 into layer5io:master Jun 29, 2025
4 of 6 checks passed
@vishalvivekm vishalvivekm mentioned this pull request Jun 29, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalvivekm vishalvivekm vishalvivekm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Image Viewer Usability with Standard Navigation
4 participants
@Jeffrin2005 @l5io @vr-varad @vishalvivekm