-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix : Social Media Share Links are Not working #6409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🚀 Preview for commit 9f6d8e0 at: https://680c8b075319cfa12ef29d79--layer5.netlify.app |
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
1 similar comment
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing these ShareButton with plain anchor tags, pointing to direct platform url, doesn't seem ideal @Jeffrin2005
We'd want to pre-fill the social media posts with link and via @<our-handles
wherever possible.
See https://www.cncf.io/blog/ for inspiration
@Jeffrin2005 Please sign off the commits Added as an agenda item to the meeting minutes |
🚀 Preview for commit e80cc9a at: https://680f5546dd51fd7cb89563bc--layer5.netlify.app |
Signed-off-by: Jeffrin Jojo <jeffrinjojo1@gmail.com>
e80cc9a
to
0cfda54
Compare
🚀 Preview for commit 0cfda54 at: https://6811d0c5b800200e687526c8--layer5.netlify.app |
Signed-off-by: Jeffrin Jojo <jeffrinjojo1@gmail.com>
8e563d3
to
d3aa29f
Compare
🚀 Preview for commit d3aa29f at: https://6811d59d995b8d1e3d94da27--layer5.netlify.app |
|
🚀 Preview for commit 9ace942 at: https://681897303e44f3134cb1202d--layer5.netlify.app |
@Jeffrin2005 Let's discuss this today in sites call. |
@Jeffrin2005 can you resolve the merge conflict? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Signed-off-by: Varad Gupta <114755221+vr-varad@users.noreply.github.com>
@LibenHailu I resolved the merge confict is this good to merge or need some changes. |
🚀 Preview for commit 86b6597 at: https://685e5f662d68264ab9da114d--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback offered on sites call still not incorporated. We don't need to get window location href, this component just needs to recieve blog permalink in addition to authorinfo and that could be uriencoded.
I'll make the update
Description
Merge Checklist
fix91.mp4
Notes for Reviewers
Signed commits