Skip to content

Refactor event listener syntax for dark mode media query in ThemeManager #6443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

leecalcote
Copy link
Member

Signed-off-by: Lee Calcote lee.calcote@layer5.io

Description

Never using browser-only APIs during server-side rendering
Consistent initial state between server and client renders
Safe detection of the browser environment
Proper handling of theme preferences that works in both environments

Signed commits

  • [x ] Yes, I signed my commits.

leecalcote added 2 commits May 9, 2025 13:43
…Manager components

Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Copy link

github-actions bot commented May 9, 2025

@l5io
Copy link
Contributor

l5io commented May 9, 2025

🚀 Preview for commit d9d01c4 at: https://681e4fbd94ae5e5a6bef60df--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented May 12, 2025

🚀 Preview for commit 1bb1beb at: https://6821e121be3ce00799ee3f26--layer5.netlify.app

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. This will handle the SSR pitfalls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants