-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add navigation link for kanvas section on layer5 website #6486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add navigation link for kanvas section on layer5 website #6486
Conversation
🚀 Preview for commit 25be30f at: https://6830cf744cb23a0074f8caf9--layer5.netlify.app |
Thank you @LibenHailu 🙌 do you have any ideas/suggestions on making this more intuitive to users? maybe changing the cursor pointer settings on hover? is it intuitive that you can go to the docs, on-click? these are just some general ux improvements that we could make. let me know if you have any ideas. |
@LibenHailu, please sign off your commits ^^ |
Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
Hi @M-DEV-1, It is important that links are distinguishable from UX perspective, there are many approach to take for that like underlined text to tell to users it is not text it is a link or using cursor pointer style or putting link icons aside, for our case we can definitely go with the cursor pointer style, one major problem can be this is not applied on mobile screens, hoping out users are developers in my opinion if we go with the cursor: pointer style we will be good. I think linking the docs there is a good UX improvement, from user perspective, I dont have any additions on this at the moment. |
🚀 Preview for commit ac040e3 at: https://6831821c47913f457d1c8a9e--layer5.netlify.app |
Hi @LibenHailu, small spelling error to fix |
hi @LibenHailu, have you incorporated the feedback given earlier? |
@LibenHailu, any updates? |
This commit is causing the DCO check to fail ^^ |
|
why dont u put that issue in slack?? @LibenHailu |
I was thinking about sending a poll on slack, the bot should be installed I reached out to some people, I will do it as soon as I get access to the poll, The idea is to know how many people are struggling to contribute due to the heavy contents we have, the question might look like Are you having an issue running the project, the choices will be yes and no, that way we can know the magnitude of the problem, in quantifiable amount, what do you think @vr-varad ? |
Hmm, okay. That works too. If you have a student ID, you should claim GitHub PRO and use 32 GB codespaces. Let's see what can be done for now. Message in #support with the exact issue, and the issue after trying out selective rendering. |
@LibenHailu Discuss that in todays' meet |
Sorry @vr-varad I am just seeing this. |
But I will post on support, unforunately I dont have student ID. |
Description
This PR fixes #6485
Notes for Reviewers
Add navigation for kanvas section.
Signed commits