Skip to content

Fixed Styles and Spacing issues in interpreting-meshery-designs #6545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

KrishnaShuk
Copy link
Contributor

@KrishnaShuk KrishnaShuk commented Jun 13, 2025

Description
This PR fixes the Image Rendering and Spacing Issue in interpreting-meshery-designs page [https://layer5.io/learn/learning-paths/mastering-meshery/introduction-to-meshery/meshery/interpreting-meshery-designs
].

This PR fixes #6535

Video for Comparison

Screencast.from.2025-06-13.08-16-45.1.mp4
  • Yes, I signed my commits.

Signed-off-by: krishnaShuk <shuklakrishna.kris@gmail.com>
@github-actions github-actions bot added the area/learn Related to /learn section label Jun 13, 2025
@l5io
Copy link
Contributor

l5io commented Jun 13, 2025

🚀 Preview for commit fa69c03 at: https://684b9e55c822640948a3b171--layer5.netlify.app

Signed-off-by: krishnaShuk <shuklakrishna.kris@gmail.com>
@l5io
Copy link
Contributor

l5io commented Jun 14, 2025

🚀 Preview for commit ea84998 at: https://684d19a5a49b7228063d0803--layer5.netlify.app

@KrishnaShuk
Copy link
Contributor Author

hey @vishalvivekm , this PR is ready. You can merge it.

@LibenHailu
Copy link
Contributor

hey @vishalvivekm , this PR is ready. You can merge it.

image
Can we center the image i think it can be fixed by removing width="100%" and giving padding, other than that it looks so much better.

@vr-varad
Copy link
Contributor

same for these images as well, u can center them as well
image

@vr-varad
Copy link
Contributor

and make images larger on small screens
image

@KrishnaShuk
Copy link
Contributor Author

Ok i will make the required changes.

@vr-varad
Copy link
Contributor

@KrishnaShuk any update?

@KrishnaShuk
Copy link
Contributor Author

@vr-varad I am in midst of my college exams. I will make a commit within 2 days.

Signed-off-by: krishnaShuk <shuklakrishna.kris@gmail.com>
@KrishnaShuk
Copy link
Contributor Author

@vr-varad I have made the required changes.

@l5io
Copy link
Contributor

l5io commented Jun 24, 2025

🚀 Preview for commit bf7676c at: https://685a2ac3e037d559c6ff9712--layer5.netlify.app

Signed-off-by: krishnaShuk <shuklakrishna.kris@gmail.com>
@l5io
Copy link
Contributor

l5io commented Jun 24, 2025

🚀 Preview for commit 84e2870 at: https://685a3aa7e037d58be5ff959d--layer5.netlify.app

@LibenHailu
Copy link
Contributor

LGMT!

@LibenHailu LibenHailu requested a review from vr-varad June 24, 2025 12:35
@vr-varad
Copy link
Contributor

@KrishnaShuk LGTM
Just One thing add spacing here between image and text.
image
Screenshot from 2025-06-24 19-23-29

then its good to merge.

@vr-varad vr-varad requested a review from vishalvivekm June 24, 2025 13:55
Signed-off-by: krishnaShuk <shuklakrishna.kris@gmail.com>
@KrishnaShuk
Copy link
Contributor Author

@vr-varad Changes done. You can merge it.

@l5io
Copy link
Contributor

l5io commented Jun 26, 2025

🚀 Preview for commit a21245d at: https://685cf729c6effd6ff02c4bc2--layer5.netlify.app

@KrishnaShuk
Copy link
Contributor Author

@vishalvivekm Changes done. You can merge it!

@vr-varad
Copy link
Contributor

@KrishnaShuk
Thank you for your contribution!
Let's discuss this during the website call today at 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/learn Related to /learn section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Display Issue on "Interpreting Meshery Designs" Page
4 participants