Fix Glitchy Animation on Academic Partners Slider During Initial Load #6528 #6574
Conversation
Signed-off-by: HIMANSHU RAI <himanshuuu.2001@gmail.com>
HIMU-2001
force-pushed
the
glitchy-animation
branch
from
2d60fd4 to
7e3f945
Compare
|
🚀 Preview for commit 7e3f945 at: https://685c0443dd0d0d0436d88d7e--layer5.netlify.app |
Signed-off-by: HIMANSHU RAI <himanshuuu.2001@gmail.com>
|
🚀 Preview for commit dd2d1ff at: https://685c09528b128b34ec6c7515--layer5.netlify.app |
There was a problem hiding this comment.
Hi @HIMU-2001 Thank you for your contribution but these are some of the things to improve to make this code merge able, the deployment link is not behaving as expected the slider is not there any more, can you check out afterChange api to track loading state it can help remove some of the abstractions here I think it uses react-slick, another improvement is the loading indicator can be improved.
|
|
||
| Promise.all(imagePromises) | ||
| .then(() => setAllImagesLoaded(true)) | ||
| .catch(() => setAllImagesLoaded(true)); // still render even if some fail |
|
🚀 Preview for commit a42fa38 at: https://685d5dc8c651b32678948198--layer5.netlify.app |
|
Hi @LibenHailu , I am preloading all partner images before rendering the slider to avoid initial load glitches. This would resolve the visual jitter caused by lazy loading or layout shifts in react-slick. I have also improved the loader ui. Screen-Recording.mp4 |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
I see, The functionality is there, which is good. |
|
Hi @LibenHailu @babiLiben , Is this mergeable or any modifications are required ? |
Hi @HIMU-2001 let's discuss this on the Monday site meeting. |
|
@HIMU-2001 Add it as an agenda item to the meeting minutes, if you would :) |
Description
This PR fixes #6528
Notes for Reviewers
Signed commits