Add support for FreeBSD #251970
Open
Add support for FreeBSD #251970
+33
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically FreeBSD can be treated as if it is Linux. So the changes are just adding process.platform === 'freebsd', process.platform !== 'freebsd', or case 'freebsd': to wherever it checks the OS is Linux with few exceptions where the check is for really Linux-specific.
There are no /proc/version file in the FreeBSD's procfs. So redirect "No such file or directory" message to /dev/null.
FreeBSD is not a glibc-based system.
The format '-o pid=,ppid=,pcpu=,pmem=,command=' is not supported by FreeBSD. So adjust it so that the arguments can be accepted by ps command on both Linux and FreeBSD.
|
@joaomoreno Please consider this PR. It seems to make @tagattie life easier to maintain the FreeBSD port. He is the official maintainer of https://www.freshports.org/editors/vscode. FYI @bpasero |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a set of changes for adding support for FreeBSD.
Basically, FreeBSD can be treated as if it is Linux. So the changes are mainly adding
process.platform === 'freebsd',process.platform !== 'freebsd', orcase 'freebsd': to wherever it checks the OS is Linux with a few exceptions where the check is for really Linux-specific.I would much appreciate it if this PR is considered for merging.
Relate PR: microsoft/vscode-deviceid#25
Related Issues: #1359, #30046, #32409, #74857, #129928