Add provider ID to terminal suggest telemetry

[Copilot]

This change enhances terminal suggest telemetry by including the provider ID in completion acceptance events. This will help understand which completion providers are most helpful and which have issues.

Changes Made

The terminal.suggest.acceptedCompletion telemetry event now includes a providerId field that identifies which completion provider supplied each accepted completion.

Technical Details

1. Data Structure: Updated _acceptedCompletions type to include providerId: string
2. Data Capture: Modified acceptCompletion method to capture completion.provider as providerId
3. Telemetry Schema: Added providerId: string | undefined to telemetry data structure with proper GDPR classification
4. Backward Compatibility: Handles cases where provider ID may be undefined gracefully

Example Telemetry Data

Before:

{
  "kind": "File",
  "outcome": "Accepted", 
  "exitCode": 0,
  "sessionId": "abc123"
}

After:

{
  "kind": "File",
  "outcome": "Accepted",
  "exitCode": 0, 
  "sessionId": "abc123",
  "providerId": "builtinPwsh"
}

This enables analysis of provider effectiveness across different shell types and completion scenarios (e.g., 'builtinPwsh', 'lsp', extension providers, etc.).

Fixes #252008.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• electronjs.org
  • Triggering command: node-gyp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Tyriar]

Let's rename this to provider instead, that matches the property on completion

[Copilot]

Renamed providerId to provider throughout the codebase to match the property name on the completion object. Commit b7b1df1

[Tyriar]

Let's verify provider is set here

[Copilot]

Added provider validation to the undefined check - now verifies that provider is set before sending telemetry data. Commit b7b1df1

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• electronjs.org
  • Triggering command: node-gyp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

[Tyriar]

@meganrogge could you verify this before merging?