-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
fix(microservices): Revisit RMQ pattern matching with wildcards #15305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
getlarge
wants to merge
3
commits into
nestjs:master
Choose a base branch
from
getlarge:fix-improve-rmq-server-pattern-matching
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(microservices): Revisit RMQ pattern matching with wildcards #15305
getlarge
wants to merge
3
commits into
nestjs:master
from
getlarge:fix-improve-rmq-server-pattern-matching
+169
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6946ab43-e618-4eb3-abcb-5a9d77424269Details
💛 - Coveralls |
@getlarge The linked PR number is wrong |
robertsLando
approved these changes
Jun 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this it's not just safer but also more performant compared to pervious approach 👍🏼
15 tasks
@kamilmysliwiec Are you waiting for something from my end? |
Ill look into this as soon as i can - still recovering after the hand surgery 🙏 |
Hardanish-Singh
approved these changes
Jul 2, 2025
Hardanish-Singh
approved these changes
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #15304
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 15304
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Before starting I asked myself, what would be the best approach?
Option 1: Keep Current Regex but Make it Safer
Tradeoffs:
Option 2: Use Map and Nested For Loop same as SeerverMQTT
Based on MQTT approach (matchMqttPattern in server-mqtt.ts:180-210):
Tradeoffs:
Option 3: Use Trie to store patterns and handlers (such as https://github.com/davedoesdev/qlobber)
Based on qlobber library:
Tradeoffs:
I went with option 2: it seems more reasonable.