-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
lib: make validateInternalField()
throw ERR_INVALID_THIS
#58765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1957faa
to
4cba46d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58765 +/- ##
==========================================
- Coverage 90.13% 90.12% -0.02%
==========================================
Files 639 639
Lines 188192 188199 +7
Branches 36916 36916
==========================================
- Hits 169633 169617 -16
+ Misses 11324 11322 -2
- Partials 7235 7260 +25
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Commit Queue failed- Loading data for nodejs/node/pull/58765 ✔ Done loading data for nodejs/node/pull/58765 ----------------------------------- PR info ------------------------------------ Title lib: make `validateInternalField()` throw `ERR_INVALID_THIS` (#58765) Author Livia Medeiros <livia@cirno.name> (@LiviaMedeiros) Branch LiviaMedeiros:lib-validate-this -> nodejs:main Labels lib / src, author ready, needs-ci Commits 2 - lib: make `validateInternalField()` throw `ERR_INVALID_THIS` - lib: rename `validateInternalField` into `validateThisInternalField` Committers 1 - LiviaMedeiros <livia@cirno.name> PR-URL: https://github.com/nodejs/node/pull/58765 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58765 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 19 Jun 2025 12:47:26 GMT ✔ Approvals: 3 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/58765#pullrequestreview-2942922771 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58765#pullrequestreview-2947030717 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58765#pullrequestreview-2947854120 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-06-22T08:41:22Z: https://ci.nodejs.org/job/node-test-pull-request/67608/ - Querying data for job/node-test-pull-request/67608/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 58765 From https://github.com/nodejs/node * branch refs/pull/58765/merge -> FETCH_HEAD ✔ Fetched commits as 745f48d9f36b..4cba46dad12b -------------------------------------------------------------------------------- [main 938b8926de] lib: make `validateInternalField()` throw `ERR_INVALID_THIS` Author: LiviaMedeiros <livia@cirno.name> Date: Thu Jun 19 20:03:15 2025 +0800 5 files changed, 13 insertions(+), 18 deletions(-) [main f8ef96a2d9] lib: rename `validateInternalField` into `validateThisInternalField` Author: LiviaMedeiros <livia@cirno.name> Date: Thu Jun 19 20:23:51 2025 +0800 8 files changed, 70 insertions(+), 70 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- lib: make `validateInternalField()` throw `ERR_INVALID_THIS`https://github.com/nodejs/node/actions/runs/15840563873 |
PR-URL: #58765 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #58765 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 745f48d...6145ba7 |
PR-URL: #58765 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #58765 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
internal/validators.validateInternalField()
has no other purpose than to validatethis
value.It must throw
ERR_INVALID_THIS
rather thanERR_INVALID_ARG_TYPE
, and ideally have more appropriate name (usedvalidateThisInternalField
).