Skip to content

deps: V8: cherry-pick 0ce2edb7adfd #58773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

deps: V8: cherry-pick 0ce2edb7adfd #58773

merged 1 commit into from
Jul 4, 2025

Conversation

kxxt
Copy link
Contributor

@kxxt kxxt commented Jun 20, 2025

Original commit message:

Fix invalid template specialization

Bug: chromium:40565911
Change-Id: If206c140e99e24a6df4ee7351e8022748eabac22
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6491420
Auto-Submit: Bruno Pitrus <brunopitrus@hotmail.com>
Commit-Queue: Jakob Linke <jgruber@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Jakob Linke <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#99987}

Refs: v8/v8@0ce2edb
Fixes: #58485

This PR fixes build error on riscv64 with gcc compiler(#58485).
This PR needs to be picked into v24.x.

Note that this PR will conflict with #58746. I will rebase #58746 once this one is merged.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jun 20, 2025
@kxxt kxxt mentioned this pull request Jun 20, 2025
Closed
lpinca
lpinca approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 24, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 24, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67643/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6628/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6628/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6628/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67646/

@kxxt
Copy link
Contributor Author

kxxt commented Jun 30, 2025

I think the failed tests are not related to this PR. It appears that the CI is flaky.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67748/

@kxxt kxxt mentioned this pull request Jul 1, 2025
Open
9 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67804/

@brjsp @targos
deps: V8: cherry-pick 0ce2edb7adfd
33b48c3 
Original commit message:

    Fix invalid template specialization

    Bug: chromium:40565911
    Change-Id: If206c140e99e24a6df4ee7351e8022748eabac22
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6491420
    Auto-Submit: Bruno Pitrus <brunopitrus@hotmail.com>
    Commit-Queue: Jakob Linke <jgruber@chromium.org>
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Jakob Linke <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#99987}

Refs: v8/v8@0ce2edb
Fixes: nodejs#58485
@targos targos force-pushed the riscv-build-fix-1 branch from 1251c04 to 33b48c3 Compare July 3, 2025 15:42
targos
targos approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased to fix a conflict. A fresh CI was needed anyway for Windows.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67816/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6644/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6644/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6644/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67824/

@targos
Copy link
Member

targos commented Jul 4, 2025

Can someone else review or @lpinca reapprove?

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 4, 2025
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2025
@nodejs-github-bot nodejs-github-bot merged commit 1539f3b into nodejs:main Jul 4, 2025
62 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1539f3b

RafaelGSS pushed a commit that referenced this pull request Jul 8, 2025
@kxxt @RafaelGSS
deps: V8: cherry-pick 0ce2edb7adfd
573171d 
Original commit message:

    Fix invalid template specialization

    Bug: chromium:40565911
    Change-Id: If206c140e99e24a6df4ee7351e8022748eabac22
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6491420
    Auto-Submit: Bruno Pitrus <brunopitrus@hotmail.com>
    Commit-Queue: Jakob Linke <jgruber@chromium.org>
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Jakob Linke <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#99987}

Refs: v8/v8@0ce2edb
Fixes: #58485
PR-URL: #58773
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@github-actions github-actions bot mentioned this pull request Jul 8, 2025
Merged
@aduh95 aduh95 added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Jul 21, 2025
@aduh95
Copy link
Contributor

aduh95 commented Jul 21, 2025

This doesn't land cleanly on v22.x-staging, if we want it on v22.x, we'd need a manual backport PR

@kxxt
Copy link
Contributor Author

kxxt commented Jul 22, 2025

This doesn't land cleanly on v22.x-staging, if we want it on v22.x, we'd need a manual backport PR

v22.x does not need this so we dont need a manual backport.

@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. and removed backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. labels Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

@targos targos

@richardlau richardlau

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node-v24.1.0 fails to build on riscv / gcc-15
7 participants
@kxxt @nodejs-github-bot @targos @aduh95 @lpinca @richardlau @brjsp