Added Confidence Argument to keypoint detection model #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SolomonLake
requested changes
Jun 4, 2025
SolomonLake
requested changes
Jun 10, 2025
SolomonLake
requested changes
Jul 7, 2025
There was a problem hiding this comment.
can you make sure you are running the tests locally using python3 -m unittest (or python) from the root of repo?
You can see test failures here: https://github.com/roboflow/roboflow-python/actions/runs/16078304796/job/45497459911?pr=354
I left suggested fixes which are all going to be necessary.
| load_dotenv(Path("../../.env")) | ||
|
|
||
|
|
||
| with open(Path("../annotations/keypoint-detection-annotations/MM2A_46_R_T_predictions.json")) as f: |
There was a problem hiding this comment.
tests get run from root -- can you update:
Suggested change
| with open(Path("../annotations/keypoint-detection-annotations/MM2A_46_R_T_predictions.json")) as f: | |
| with open(Path("tests/annotations/keypoint-detection-annotations/MM2A_46_R_T_predictions.json")) as f: |
|
|
||
|
|
||
| class TestKeypointDetection(unittest.TestCase): | ||
| api_key = os.getenv("ROBOFLOW_API_KEY") |
There was a problem hiding this comment.
Suggested change
| api_key = os.getenv("ROBOFLOW_API_KEY") | |
| api_key = os.getenv("ROBOFLOW_API_KEY", "test-api-key") |
|
|
||
| responses.add(responses.POST, self.api_url, json=MOCK_RESPONSE, status=200) | ||
|
|
||
| result = instance.predict("/roboflow-python/tests/images/MM2A_46_R_T.png") |
There was a problem hiding this comment.
Suggested change
| result = instance.predict("/roboflow-python/tests/images/MM2A_46_R_T.png") | |
| result = instance.predict("tests/images/MM2A_46_R_T.png") |
and change the other .png references too
|
|
||
| responses.add(responses.POST, self.api_url, json={"error": "Invalid API key"}, status=401) | ||
|
|
||
| with self.assertRaises(HTTPError): |
There was a problem hiding this comment.
Suggested change
| with self.assertRaises(HTTPError): | |
| with self.assertRaises(Exception): |
do this to avoid failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new "Confidence" argument has been added to the keypoint detection model (based on the confidence argument found in the object detection model)
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
A Dedicated keypoint detection model test file has been made with multiple test cases including one where the confidence is changed
Any specific deployment considerations
Docs