Skip to content

Port To TelepathyGLib #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Creatune
Copy link

@Creatune Creatune commented Jan 16, 2020

Worked after porting.
@pro-panda @tchx84 @quozl please review :)

@Creatune
Copy link
Author

Creatune commented Jan 16, 2020

I used:
quozl/record-activity@38ffc78
as reference.

@chimosky
Copy link
Member

Tested, activity isn't shared and logs show.

/home/ibiam/Activities/cartoon-builder/toolkit/activity.py:24: PyGIWarning: TelepathyGLib was imported without specifying a version first. Use gi.require_version('TelepathyGLib', '0.12') before import to ensure that the right version gets loaded.
  from gi.repository import TelepathyGLib
Traceback (most recent call last):
  File "/home/ibiam/Activities/cartoon-builder/toolkit/activity.py", line 281, in _shared_cb
    self._sharing_setup()
  File "/home/ibiam/Activities/cartoon-builder/toolkit/activity.py", line 305, in _sharing_setup
    self._conn = self._shared_activity.telepathy_conn
AttributeError: 'CartoonBuilderActivity' object has no attribute '_shared_activity'

@quozl
Copy link
Contributor

quozl commented Jan 17, 2020

The error suggests the activity may not have been tested for collaboration after a port to GTK 3; it will be necessary to fix and test that before or during port to TelepathyGLib. It should be a simple change to use get_shared_activity, if I recall correctly.

@quozl
Copy link
Contributor

quozl commented Jan 22, 2020

G'day @Creatune, do you plan to finish this pull request?

@quozl quozl mentioned this pull request Jan 22, 2020
@quozl
Copy link
Contributor

quozl commented Jan 23, 2020

Thanks. Tested. Collaboration doesn't share any application state. Logs contain;

$ sugar-activity
1579767406.804880 WARNING root: Activity written for Python 2, consider porting to Python 3.
/usr/share/sugar/activities/CartoonBuilder.activity/toolkit/activity.py:24: PyGIWarning: TelepathyGLib was imported without specifying a version first. Use gi.require_version('TelepathyGLib', '0.12') before import to ensure that the right version gets loaded.
  from gi.repository import TelepathyGLib
Traceback (most recent call last):
  File "/usr/share/sugar/activities/CartoonBuilder.activity/toolkit/activity.py", line 281, in _shared_cb
    self._sharing_setup()
  File "/usr/share/sugar/activities/CartoonBuilder.activity/toolkit/activity.py", line 305, in _sharing_setup
    self._conn = self.get_shared_activity.telepathy_conn
AttributeError: 'function' object has no attribute 'telepathy_conn'

How did you test collaboration, @Creatune?

@Creatune
Copy link
Author

I did not test yet. I am still figuring out how to set up a collaboration environment. This was just a hunch of mine. I will let you know when I complete the setup. Sorry for the inconvenience.

@chimosky
Copy link
Member

@Creatune you can setup another vm and use that to test collaboration, run both vms and check the neighbourhood if you'll see two instances - check both -

@srevinsaju
Copy link
Member

@Creatune ping

@Creatune
Copy link
Author

Hi @srevinsaju. I am currently busy and will start contributing in March. You can take this over if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants