Skip to content

Issue fix custom temperament #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rashap224
Copy link

Issue Reference: Fixes #3798

Description:
This pull request addresses the issue of limited functionality when using custom temperaments in Music Blocks. The following enhancements have been implemented:

1. Define Mode Block:

  • Modified to accept any whole number as input.
  • Applied modulo math based on the cardinality of the temperament system to ensure valid pitch numbers.

2. New Temperament Length Block:

  • Added a new block that outputs the cardinality (number of pitches) of the current temperament system.

3. Improved Integration:

  • Enhanced compatibility with "Nth Modal Pitch" and "Scalar Step" blocks by mapping defined modal pitches to numeric pitch classes.

Acceptance Tests:

  • Verified functionality using the provided test files and scenarios.
  • Ensured compatibility with custom temperament systems of varying cardinalities.

Copy link

✅ All Jest tests passed! This PR is ready to merge.

@rashap224
Copy link
Author

@pikurasa Please review this PR.

@pikurasa
Copy link
Collaborator

@rashap224 Please only include commits related to the issue you are solving with your PR.

Copy link

This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the stale label is removed or commented on.

@github-actions github-actions bot added the Stale label Jun 27, 2025
Copy link

github-actions bot commented Jul 1, 2025

Closed pull request due to inactivity for more than 63 days.

@github-actions github-actions bot closed this Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pitch Number, Set Key, and Nth Modal Pitch integration for Temperament
2 participants