remove: delete obsolete cache.appcache file #4664
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender, could you kindly advise which documentation file would be most appropriate for adding a note about the removal of the deprecated file? |
|
Maybe the Readme in the lib dir? |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender Please review. |
|
I thought you were going to add info about how/when to deprecate packages to the Readme. We don't need to add this specific explanation. It should be in the commit message. |
Ubayed-Bin-Sufian
force-pushed
the
chore/remove_cache.appcache
branch
from
06fa60a to
93907e8
Compare
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@walterbender I misunderstood. I suggest a change. Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4665
Summary
This PR removes the deprecated
cache.appcachefile from the project. AppCache is an obsolete feature that is no longer supported in modern browsers due to security and performance concerns.The removal aligns with best practices outlined in the following resources:
Chrome Developer Lighthouse: AppCache Manifest
Meteor Documentation: AppCache Package
Chromium Blink Dev Discussion on AppCache Deprecation
We have already migrated to a Service Worker-based approach for offline functionality, as implemented in sw.js, making the AppCache file redundant.
Checklist
cache.appcachefrom the codebase