This PR fixes a UI delay issue where the setInstrument and start sidebars only expand or contract after the mouse leaves the note value block expand/collapse button. #4666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and start sidebar when note value blocks are expanded or contracted
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@prince9 Thanks for attempting.
This way maintainers can easily understand your intent. |
|
@Prince9g which issue i was unable to find any !! :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a UI delay issue where the setInstrument and start sidebars only expand or contract after the mouse leaves the note value block expand/collapse button. The new behavior ensures that the sidebar updates happen immediately on button click.
Changes Made:
Added onclick event listeners to collapseButtonBitmap and expandButtonBitmap inside _generateCollapseArtwork().
On click, the block's collapsed state updates and the visual state is refreshed with show().
Calls blocks.expandOrCollapseSidebars() (if defined) to update the sidebar instantly.
Expected Behavior:
When the user clicks the expand or collapse button on a note value block, the start and setInstrument sidebars now update immediately, without needing mouse movement.
Issue Reference:
Fixes issue: "Late expansion and contraction of setInstrument and start sidebar when note value blocks are expanded or contracted."