-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add documentation for program blocks including heap and boxes #4678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ All Jest tests passed! This PR is ready to merge. |
This is a nice addition. It would be even better if there was an example of its use with a MB program. Perhaps something like recording and playing back notes? |
@walterbender Thank you for the feedback! -Recording notes with timing information using the heap. // Initialize our note recorder // Start recording notes // Visual indicator that recording has started // Record a note when it's played // Save the note data (timestamp, note value, and duration) // Add to our recorded notes array // Visual feedback // rest of the recording/playback example |
The example should be coded in Music Blocks |
✅ All Jest tests passed! This PR is ready to merge. |
@walterbender I have added the heap and note recording examples as suggested and I have revised the PR. Please review when you have a moment. |
The example would be fine if MB was a text-based language. But it is block-based. Please create a visual similar to all of the other examples in the guide. |
Should I create a simple Music Blocks program that demonstrates: -Basic heap operations (set/load)
|
Yes. Note that there is a save block art work option in advanced mode -- an SVG of your project. |
Hi @walterbender ,
Here's the SVG image showing the implementation: I have covered this following points :-
Could you please review this and let me know if any additional details or changes are needed? Thanks! |
Are you sure you attached the correct image? |
@walterbender In the image I shared, please focus on the left side which demonstrates the heap operations:
The other blocks on the right (music notes, drums, etc.) are unrelated to the heap example and can be ignored for this discussion. I included them because they were part of my workspace, but only the left-side blocks are relevant to showing heap functionality. Would you prefer if I:
Please let me know which would be more helpful for the documentation. |
hey @walterbender should i proceed further , is this issue is still relevant?? |
It would be nice to finish this up. |
Fix: #3844 Add documentation for program blocks including heap and box blocks
-Explained key blocks: Set Heap, Load Heap, Store in Box, Add One, etc.
-Provided a clear example to demonstrate usage in musical programs.
Fixes:- #3844