Skip to content

Removed legacy icons, outdated jQuery version, and sugar-web library.… #4689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

asmit990
Copy link

… Updated jQuery from 2.1.4 to 3.7.1.
.... Removed legacy icons
... Removed cache.appcache
... Removed sugar-web

Copy link

✅ All Jest tests passed! This PR is ready to merge.

@walterbender
Copy link
Member

(1) what are all these .bak files for?
(2) how did you test this?
(3) it would be good to split disparate changes into separate PRs.

@walterbender
Copy link
Member

I understand the .bak might designate a backup file. But given that we use git, we don't need backup files.

Can you please go into more detail about how you tested?

@asmit990
Copy link
Author

You’re absolutely right — since we’re using Git for version control, .bak files aren’t necessary. I had initially created .bak files as a precaution during the cleanup and replacement process (especially with sed operations), but since all changes are tracked by Git, I’ve now removed them from the working directory.

Testing Approach:

To ensure correctness and that nothing breaks visually or functionally:
1. Manual Visual Inspection:
• Opened the main HTML pages (index.html, guide/index.html, etc.) in a browser before and after changes.
• Verified that pages load correctly and there are no missing icons or broken layouts.
• Checked browser console for any JavaScript errors — none were found.
2. Functionality Checks:
• Interacted with key UI elements to ensure they still respond (e.g., menus, buttons, interactive scripts).
• Verified that dynamic scripts like Tone.js, webL10n, and materialize.min.js load as expected.
3. Diff Review:
• Ran git diff to validate that only the intended lines were modified — mainly removing unused or commented <script> tags and icon references.
• Ensured that no essential functionality was accidentally removed.
4. Cleanup Confirmation:
• Removed all .bak and temporary files created during sed usage.
• Ran git status to confirm a clean working directory before final commit.

@asmit990
Copy link
Author

asmit990 commented May 17, 2025

I made a proposal too
Can you check that
Its by NAME ASMIT PANDEY

Copy link

This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the stale label is removed or commented on.

@github-actions github-actions bot added the Stale label Jul 16, 2025
Copy link

Closed pull request due to inactivity for more than 63 days.

@github-actions github-actions bot closed this Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants