-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
v6: Sass modules only #41512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
v6: Sass modules only #41512
Conversation
I'm glad to have started considering this and look forward to updates |
I have just spent a week converting 5.3.3 to use namespace removing all @imports and using @use/@forward. I have created a 5.3.6 version (on my system) that I would be willing to share for those using the newest version of PhpStorm which advanced dart sass and deprecated @import. This is a temporary fix until v6 is released and I would be willing to share. |
77b5a29
to
a66964b
Compare
Not the way we want to do it. It requires changing all our imports, and to allow the new Dart Sass customization methods, it feels like the right approach to refactor some things now. It was suggested to us that we could double the number of files we have and so some custom forwarding (I think Core UI did this with their Bootstrap fork), but that pollutes the codebase and makes things much less approachable. Making the dependencies and modules super clear feels right at this time. |
03b0c2e
to
3371816
Compare
@use "../colors" as *; | ||
@use "../config" as *; | ||
@use "../variables" as *; | ||
|
||
// All-caps `RGBA()` function used because of this Sass bug: https://github.com/sass/node-sass/issues/2251 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to remember checking it, maybe we can switch to rgba()
or color-mix()
in this file and _colored-links.scss
.
@@ -140,7 +140,7 @@ As part of Bootstrap’s evolving CSS variables approach, alerts now use local C | |||
|
|||
<DeprecatedIn version="5.3.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's going to be a major version, we'll need to get rid (and probably document in the migration guide) all the things that were deprecated in v5.
@ajiho, as @mdo mentioned, the only way to maintain backward compatibility is to double the number of files by adding a |
1388120
to
b93b4c4
Compare
This is a WIP effort to pull out the Sass module changes from my v6 branch to see how minimal we can make an earlier release to get folks onto newer versions of Dart Sass, Sass modules, etc. TBD if we do this, but wanted to try over the weekend. Still a few more things to bring in here, but it's getting close. I think the
_maps
and_variables-dark
are my current biggest problems.This branch aims to:
@import
with@use
and@forward
, including in our documentation.scss/
directory with additional subfolders.Optional changes that feel within reason of a more focused v6 release:
What's not coming that would be moved to a faster v7 release:
!important
for layers, streamlining keysProbably some other things to pull out too, but wanted to spike this out.