Skip to content

Overall LGTM - and very welcome! I especially appreciate modernizing older tests to be .any.js. A couple things: #53462

Open
@Ampjadams

Description

@Ampjadams

Overall LGTM - and very welcome! I especially appreciate modernizing older tests to be .any.js. A couple things:

  • Is the change to give an absolute path for META includes (e.g. resources/encodings.js/encoding/resources/encodings.js) required? WPTs use a mix; if this is now required for shadowrealm tests then documentation somewhere would be great. (Apologies if this is a well known issue, I haven't kept up with WPT evolution for a bit.)
  • Some of the checks are because Chrome and Firefox don't support SABs with the APIs and the tests fail - those are known issues, not a problem. The timeouts because AudioWorklet doesn't support shadow realm are probably new. It would be nice to rework the tests to fail quickly rather than timing out, as timeouts for the CI infrastructure wastes resources.

Apologies for the delay in providing feedback.

Originally posted by @inexorabletash in #49286 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions