Skip to content

Added scheduler unit testcases #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

kimeunju108
Copy link
Collaborator

@kimeunju108 kimeunju108 commented Jun 8, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR presents unit testcases of added functions of scheduler. The functions are:

  • updateFlavorCount()
  • GetRegionFlavors()
  • BindResource()
  • withdrawResource()

Which issue(s) this PR fixes:
Fixes #286

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

How to test?:
$ cd go/src/k8s.io/kubernetes (not go/src/k8s.io/arktos)
$ cd globalscheduler/pkg/scheduler/sitecacheinfo
$ go test .
$ cd globalscheduler/pkg/scheduler/internal/cache
$ go test .
$ globalscheduler/pkg/scheduler/framework/plugins/defaultbinder
$ go test .
$ globalscheduler/pkg/scheduler
$ go test .

@kimeunju108 kimeunju108 requested review from pdgetrf and removed request for pdgetrf June 10, 2021 22:33
@pdgetrf
Copy link
Collaborator

pdgetrf commented Jun 11, 2021

please add requested reviewers.

)

func TestSkipStackUpdate(t *testing.T) {
/*func TestSkipStackUpdate(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revoke cluster resources when scheduling failed to create a vm
3 participants