-
Notifications
You must be signed in to change notification settings - Fork 183
refactor(protocol-designer): allow for multiple lid selection #18739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -135,6 +141,10 @@ export function CustomizeExpandButton( | |||
) | |||
} | |||
|
|||
export const CustomizeExpandButton: MemoExoticComponent< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess i'm not sure if this is needed. thought it helped with this bug https://opentrons.atlassian.net/browse/AUTH-1916 but it did not
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18739 +/- ##
==========================================
- Coverage 27.07% 24.81% -2.27%
==========================================
Files 3246 3305 +59
Lines 257281 287032 +29751
Branches 26866 35287 +8421
==========================================
+ Hits 69671 71234 +1563
- Misses 187588 215777 +28189
+ Partials 22 21 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
protocol-designer/src/components/organisms/SelectLabwareModal/SelectLabware.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/organisms/SelectLabwareModal/SelectLabwareOnAdapter.tsx
Show resolved
Hide resolved
protocol-designer/src/components/organisms/SelectLabwareModal/SelectLabwareOnAdapter.tsx
Show resolved
Hide resolved
protocol-designer/src/components/organisms/SelectLabwareModal/SelectLidOnLabware.tsx
Show resolved
Hide resolved
@ncdiehl11 - oh, dang, its because you can stack that labware. i think this is the only labware with this issue. i'll add a ticket to address it in a follow up since its a special-case. Good catch!
Hehe that copy wasn't in the designs so i will update it to you suggestion and have Design call it out later for DQA
Yes, its not fully wired up yet. EXEC will wire it up for flex stacker work! |
I made a ticket to address item 1: https://opentrons.atlassian.net/browse/AUTH-2033 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of small comments for efficiency but works well given the followups!
protocol-designer/src/assets/localization/en/starting_deck_state.json
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/organisms/SelectLabwareModal/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮
partially addresses AUTH-1945
Overview
NOTE: there is a bug right now where if you click a checkbox and un click it, it scrolls down to a bunch of white space at the bottom of the modal. that is a bug that will be addressed separately
This PR fixes the designs to allow for multiple lids to be selected. It switches between a checkbox vs 2 options to select.
With 1 lid option:

With 2 lid options:

Test Plan and Hands on Testing
Turn on the stacking ff
click to add the Tough 96 well plate and see that there are 2 lid options. select one and add. should be the plate + lid added to the deck. The clear button in the toolbox should delete both
Changelog
SelectLabwareModal
to multiple components to allow for easier readabilityRisk assessment
low