-
Notifications
You must be signed in to change notification settings - Fork 183
feat(opentrons-ai-client): Settings page #18748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I skimmed this, but @koji is probably better at reviewing frontend code like this.
7c30ff3
to
9a912a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18748 +/- ##
==========================================
- Coverage 26.12% 26.10% -0.02%
==========================================
Files 3290 3304 +14
Lines 287098 287280 +182
Branches 29598 29595 -3
==========================================
+ Hits 75005 75006 +1
- Misses 212062 212243 +181
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
opentrons-ai-client/src/components/organisms/Settings/FeatureFlag.tsx
Outdated
Show resolved
Hide resolved
opentrons-ai-client/src/components/organisms/Settings/Privacy.tsx
Outdated
Show resolved
Hide resolved
opentrons-ai-client/src/components/organisms/Settings/FeatureFlag.tsx
Outdated
Show resolved
Hide resolved
opentrons-ai-client/src/components/organisms/Settings/FeatureFlag.tsx
Outdated
Show resolved
Hide resolved
opentrons-ai-client/src/pages/Settings/__tests__/Settings.test.tsx
Outdated
Show resolved
Hide resolved
opentrons-ai-client/src/pages/Settings/__tests__/Settings.test.tsx
Outdated
Show resolved
Hide resolved
opentrons-ai-client/src/pages/Settings/__tests__/Settings.test.tsx
Outdated
Show resolved
Hide resolved
opentrons-ai-client/src/components/organisms/Settings/__tests__/Privacy.test.tsx
Outdated
Show resolved
Hide resolved
opentrons-ai-client/src/components/organisms/Settings/__tests__/FeatureFlag.test.tsx
Outdated
Show resolved
Hide resolved
opentrons-ai-client/src/pages/Settings/__tests__/Settings.test.tsx
Outdated
Show resolved
Hide resolved
opentrons-ai-client/src/pages/Settings/__tests__/Settings.test.tsx
Outdated
Show resolved
Hide resolved
opentrons-ai-client/src/pages/Settings/__tests__/Settings.test.tsx
Outdated
Show resolved
Hide resolved
opentrons-ai-client/src/components/organisms/Settings/Privacy.tsx
Outdated
Show resolved
Hide resolved
6ac40fe
to
4cb043b
Compare
Overview
Closes AUTH-2016
We introduce Settings page to control if the user wants their data to be used by OpentronsAI or not.
Test Plan and Hands on Testing
CI
Review requests
Risk assessment
Low