Skip to content

feat(opentrons-ai-client): Settings page #18748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 3, 2025
Merged

Conversation

Elyorcv
Copy link
Contributor

@Elyorcv Elyorcv commented Jun 26, 2025

Overview

Closes AUTH-2016

We introduce Settings page to control if the user wants their data to be used by OpentronsAI or not.

image

Test Plan and Hands on Testing

CI

Review requests

  • Please go to landing page
  • Click Settings icon - top right
  • See the Settings page

Risk assessment

Low

@Elyorcv Elyorcv marked this pull request as ready for review June 26, 2025 16:11
@Elyorcv Elyorcv requested a review from a team as a code owner June 26, 2025 16:11
Copy link
Collaborator

@ddcc4 ddcc4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I skimmed this, but @koji is probably better at reviewing frontend code like this.

@Elyorcv Elyorcv force-pushed the AUTH-2016-add-settings-page branch from 7c30ff3 to 9a912a3 Compare June 27, 2025 10:12
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.10%. Comparing base (094291c) to head (4cb043b).
Report is 3 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18748      +/-   ##
==========================================
- Coverage   26.12%   26.10%   -0.02%     
==========================================
  Files        3290     3304      +14     
  Lines      287098   287280     +182     
  Branches    29598    29595       -3     
==========================================
+ Hits        75005    75006       +1     
- Misses     212062   212243     +181     
  Partials       31       31              
Flag Coverage Δ
protocol-designer 19.10% <ø> (-0.01%) ⬇️
step-generation 5.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Elyorcv Elyorcv force-pushed the AUTH-2016-add-settings-page branch from 6ac40fe to 4cb043b Compare July 3, 2025 09:02
@Elyorcv Elyorcv merged commit 7daea58 into edge Jul 3, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants