-
Notifications
You must be signed in to change notification settings - Fork 183
feat(protocol-designer): add warning about dangerous submerge/retract position #18825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer): add warning about dangerous submerge/retract position #18825
Conversation
… position In analysis, we determine whether the submerge/retract location for a given liquid transfer is deemed to be within the specified well's liquid. We are afforded this since the API calculates the liquid meniscus height in a all wells throughout the protocol. However, we do not have access to this logic in Protocol Designer. Due to this reality, we cannot know for sure whether a submerge/retract position set inside a well is safely above the meniscus level. The resolution is to warn the user that their submerge/retract position may result in analysis failure if the tip is in fact below the calculated liquid meniscus at the time of the pipette movement. Closes RQA-4334
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.5.0 #18825 +/- ##
=======================================================
Coverage 27.70% 27.70%
=======================================================
Files 3204 3204
Lines 250439 250480 +41
Branches 26320 26321 +1
=======================================================
+ Hits 69380 69405 +25
- Misses 181042 181058 +16
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
protocol-designer/src/components/organisms/TipPositionModal/index.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/organisms/TipPositionModal/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple of nits but smoke tested and works well!
Overview
In analysis, we determine whether the submerge/retract location for a given liquid transfer is deemed to be within the specified well's liquid. We are afforded this since the API calculates the liquid meniscus height in a all wells throughout the protocol. However, we do not have access to this logic in Protocol Designer. Due to this reality, we cannot know for sure whether a submerge/retract position set inside a well is safely above the meniscus level. The resolution is to warn the user that their submerge/retract position may result in analysis failure if the tip is in fact below the calculated liquid meniscus at the time of the pipette movement.
Closes RQA-4334
Test Plan and Hands on Testing
Changelog
Review requests
see test plan
Risk assessment
low