refactor(shared-data): Rename getModuleDef2() -> getModuleDef()

[SyntaxColoring]

Overview

This function is called getModuleDef2() because it used to return ModuleDefinition2 (module definition schema 2). It's actually returned schema 3 for a while, but its name never got updated.

Test Plan and Hands on Testing

Just existing automated tests.

Changelog

Rename getModuleDef2() -> getModuleDef().

Review requests

None.

Risk assessment

Very low.

[codecov]

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.13%. Comparing base (1e8c527) to head (4f50e17).
Report is 646 commits behind head on edge.

Files with missing lines	Patch %	Lines
components/src/hardware-sim/BaseDeck/BaseDeck.tsx	66.66%	1 Missing ⚠️
...onents/src/hardware-sim/Deck/MoveLabwareOnDeck.tsx	0.00%	1 Missing ⚠️
...are-library/src/labware-creator/fieldsToLabware.ts	50.00%	1 Missing ⚠️
.../src/pages/Designer/DeckSetup/DeckSetupDetails.tsx	0.00%	1 Missing ⚠️
...ner/src/pages/Designer/DeckSetup/FixtureRender.tsx	0.00%	1 Missing ⚠️
...rc/pages/ProtocolOverview/DeckThumbnailDetails.tsx	0.00%	1 Missing ⚠️
...eration/src/utils/createTimelineFromRunCommands.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             edge   #18834      +/-   ##
==========================================
+ Coverage   54.65%   57.13%   +2.47%     
==========================================
  Files        3258     3264       +6     
  Lines      281773   284168    +2395     
  Branches    29494    36410    +6916     
==========================================
+ Hits       153998   162353    +8355     
+ Misses     127585   121616    -5969     
- Partials      190      199       +9     

Flag	Coverage Δ
app	47.52% <61.53%> (+0.22%)	⬆️
protocol-designer	19.41% <30.76%> (+0.71%)	⬆️
step-generation	5.44% <7.69%> (+1.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
app/src/molecules/ModuleInfo/ModuleInfo.tsx	77.89% <100.00%> (+4.21%)	⬆️
...anisms/ErrorRecoveryFlows/hooks/useDeckMapUtils.ts	62.53% <100.00%> (ø)
.../organisms/InterventionModal/__fixtures__/index.ts	94.09% <100.00%> (+5.45%)	⬆️
.../InterventionModal/utils/getRunModuleRenderInfo.ts	100.00% <100.00%> (ø)
...transformations/analysis/getProtocolModulesInfo.ts	66.66% <100.00%> (-4.17%)	⬇️
...nts/src/hardware-sim/Module/Thermocycler/index.tsx	37.03% <100.00%> (ø)
...gner/src/components/organisms/Ot2Modules/index.tsx	79.18% <100.00%> (+79.18%)	⬆️
...igner/src/pages/Designer/DeckSetup/ModuleLabel.tsx	89.04% <100.00%> (ø)
...ner/src/pages/Designer/DeckSetup/SelectedItems.tsx	98.27% <100.00%> (+98.27%)	⬆️
shared-data/js/modules.ts	91.66% <100.00%> (+25.00%)	⬆️
... and 7 more

... and 1680 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mjhuff]

Thanks!