Skip to content

feat(app): remove position screen from delay #18836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025

Conversation

koji
Copy link
Contributor

@koji koji commented Jul 4, 2025

Overview

remove position screen from delay

close AUTH-2035

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

remove position screen from delay

close AUTH-2035
@koji koji requested review from ncdiehl11 and jerader July 4, 2025 02:32
@koji koji marked this pull request as ready for review July 4, 2025 02:40
@koji koji requested a review from a team as a code owner July 4, 2025 02:40
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -56,7 +56,7 @@
"delay_before_dispensing": "Delay before dispensing",
"delay_duration_s": "Delay duration (seconds)",
"delay_position_mm": "Delay position from bottom of well (mm)",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this, right?

Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.32%. Comparing base (396b013) to head (0fbf869).
Report is 4 commits behind head on edge.

Files with missing lines Patch % Lines
...ansferFlow/QuickTransferAdvancedSettings/Delay.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #18836       +/-   ##
===========================================
- Coverage   62.81%   27.32%   -35.49%     
===========================================
  Files        3250     3250               
  Lines      257655   257418      -237     
  Branches    32757    32554      -203     
===========================================
- Hits       161846    70342    -91504     
- Misses      95611   187059    +91448     
+ Partials      198       17      -181     
Flag Coverage Δ
app 2.06% <0.00%> (-45.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...erFlow/Aspirate/hooks/useAspirateSettingsConfig.ts 0.00% <ø> (-1.23%) ⬇️
...erFlow/Dispense/hooks/useDispenseSettingsConfig.ts 0.00% <ø> (-52.03%) ⬇️
...ansferFlow/QuickTransferAdvancedSettings/index.tsx 0.00% <ø> (-92.67%) ⬇️
app/src/organisms/ODD/QuickTransferFlow/types.ts 100.00% <ø> (ø)
...ansferFlow/QuickTransferAdvancedSettings/Delay.tsx 0.00% <0.00%> (-96.99%) ⬇️

... and 1657 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji merged commit b1c15cc into edge Jul 7, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants