-
Notifications
You must be signed in to change notification settings - Fork 183
feat(components) CSS Modules-add files for CSS variables #18838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add new css files for variables close AUTH-
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18838 +/- ##
==========================================
+ Coverage 26.84% 28.14% +1.29%
==========================================
Files 3252 3252
Lines 257814 256693 -1121
Branches 32609 32301 -308
==========================================
+ Hits 69223 72243 +3020
+ Misses 188567 184432 -4135
+ Partials 24 18 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thank you!
Overview
add
global.module.css
for CSS variablesthis pr itself doesn't do anything until we create a componentName.module.css and use a variable from
global.module.css
.close AUTH-2036
Test Plan and Hands on Testing
check this pr doesn't break anything
Changelog
Review requests
Risk assessment
low