Skip to content

feat(components) CSS Modules-add files for CSS variables #18838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 8, 2025

Conversation

koji
Copy link
Contributor

@koji koji commented Jul 4, 2025

Overview

add global.module.css for CSS variables
this pr itself doesn't do anything until we create a componentName.module.css and use a variable from global.module.css.

close AUTH-2036

Test Plan and Hands on Testing

check this pr doesn't break anything

  • old ui components on Storybook
  • labware related projects

Changelog

Review requests

Risk assessment

low

@koji koji marked this pull request as ready for review July 4, 2025 19:52
@koji koji requested review from a team as code owners July 4, 2025 19:52
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.14%. Comparing base (5d6e238) to head (c1cc319).
Report is 3 commits behind head on edge.

Files with missing lines Patch % Lines
app/src/index.tsx 0.00% 1 Missing ⚠️
protocol-designer/src/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18838      +/-   ##
==========================================
+ Coverage   26.84%   28.14%   +1.29%     
==========================================
  Files        3252     3252              
  Lines      257814   256693    -1121     
  Branches    32609    32301     -308     
==========================================
+ Hits        69223    72243    +3020     
+ Misses     188567   184432    -4135     
+ Partials       24       18       -6     
Flag Coverage Δ
app 2.89% <0.00%> (+2.56%) ⬆️
components 4.66% <0.00%> (+0.06%) ⬆️
opentrons-ai-client 3.20% <0.00%> (-0.01%) ⬇️
protocol-designer 19.14% <0.00%> (-0.01%) ⬇️
step-generation 5.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/src/index.tsx 0.00% <0.00%> (ø)
protocol-designer/src/index.tsx 0.00% <0.00%> (ø)

... and 198 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji requested a review from jerader July 7, 2025 23:08
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

@koji koji merged commit 2e0e2c3 into edge Jul 8, 2025
68 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants