chore(monorepo): add a new rule for css modules migration #18839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a new rule for css modules migration close AUTH-
There was a problem hiding this comment.
Pull Request Overview
Adds a new ESLint override to warn on inline styles in .tsx files, guiding migration to CSS modules.
- Introduces the
react/forbid-dom-propsrule to forbid thestyleprop in TSX files (excluding story files) - Temporarily set to
warnto accommodate existing inline-style usage
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
koji
requested review from
sfoster1,
SyntaxColoring,
TamarZanzouri,
smb2268,
Elyorcv,
ncdiehl11,
mjhuff and
jerader
Elyorcv
approved these changes
Jul 8, 2025
| files: ['**/*.tsx'], | ||
| excludedFiles: ['**/*.stories.tsx'], | ||
| rules: { | ||
| // TODO: Switch this rule to 'error' once the CSS modules migration is complete. |
There was a problem hiding this comment.
could we create a ticket for this and put here?
SyntaxColoring
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
add a new rule for css modules migration
at this moment, this sets
warninsteaderrorbecasue there are some components that usestyleinapp,protocol-designer, andopentrons-ai-clientwhen i set
error, there were 115 errors.close AUTH-
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment