refactor(components): resolve buttons' nested structure #18840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use Btn as the base component to resolve buttons' nested structure close AUTH-2038
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18840 +/- ##
===========================================
+ Coverage 27.12% 62.81% +35.68%
===========================================
Files 3250 3250
Lines 257453 257660 +207
Branches 26841 32757 +5916
===========================================
+ Hits 69835 161845 +92010
+ Misses 187596 95617 -91979
- Partials 22 198 +176
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ncdiehl11
reviewed
Jul 7, 2025
| background-color: ${COLORS.red50}; | ||
| border-radius: ${BORDERS.borderRadius8}; | ||
| padding-left: ${SPACING.spacing16}; | ||
| padding-right: ${SPACING.spacing16}; | ||
| padding: ${SPACING.spacing8} ${SPACING.spacing16}; |
There was a problem hiding this comment.
Do we intentionally add top/bottom padding of 8px here?
There was a problem hiding this comment.
yes, the button doesn't enough height without the top and bottom padding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
use Btn as the base component to resolve buttons' nested structure
close AUTH-2038
Test Plan and Hands on Testing
compare storybooks
edgehttps://s3-us-west-2.amazonaws.com/opentrons-components/edge/index.html?path=/story/helix-atoms-buttons--alt-primary-button
this branchChangelog
Review requests
Risk assessment
low