Skip to content

fix(step-generation): remove indent from load liquid array #18842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jul 7, 2025

Overview

remove indent from wells array in load liquid command

Test Plan and Hands on Testing

Review code and smoke test but the indent after the closing wells array bracket should no longer be there

Changelog

remove indent

Risk assessment

low

@jerader jerader requested a review from a team as a code owner July 7, 2025 18:20
@jerader jerader requested a review from ddcc4 July 7, 2025 18:20
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.62%. Comparing base (cb4f90a) to head (84dd9c6).
Report is 1 commits behind head on chore_release-pd-8.5.0.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           chore_release-pd-8.5.0   #18842      +/-   ##
==========================================================
+ Coverage                   24.27%   24.62%   +0.34%     
==========================================================
  Files                        3309     3263      -46     
  Lines                      288411   282677    -5734     
  Branches                    30301    30248      -53     
==========================================================
- Hits                        70026    69601     -425     
+ Misses                     218365   213056    -5309     
  Partials                       20       20              
Flag Coverage Δ
protocol-designer 19.11% <0.00%> (ø)
step-generation 5.26% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
step-generation/src/utils/pythonFileUtils.ts 84.27% <100.00%> (-5.34%) ⬇️

... and 174 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks correct to me

@jerader jerader merged commit 0f51ada into chore_release-pd-8.5.0 Jul 7, 2025
24 checks passed
@jerader jerader deleted the sg_remove-indent-liquid branch July 7, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants