-
Notifications
You must be signed in to change notification settings - Fork 183
final docs callouts #18843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
final docs callouts #18843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments. We should be on track to merge this today and tag docs@2.24
.
api/docs/v2/liquid_classes.rst
Outdated
@@ -128,6 +128,8 @@ Using Liquid Classes | |||
|
|||
You'll use a :ref:`liquid class definition <liquid-class-definitions>` in your protocol to optimize transfer behavior based on liquid properties, along with your chosen Flex pipettes and tips. | |||
|
|||
This section covers selecting a liquid class and using the :py:meth:`.InstrumentContext.transfer_with_liquid_class` method. For more details, including using the :py:meth:`.InstrumentContext.distribute_with_liquid_class` and :py:meth:`.InstrumentContext.consolidate_with_liquid_class` methods, see :ref:`v2-complex-commands`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The full names here make the paragraph wrap in a way that's hard to read. Let's use the shortened versions.
This section covers selecting a liquid class and using the :py:meth:`.InstrumentContext.transfer_with_liquid_class` method. For more details, including using the :py:meth:`.InstrumentContext.distribute_with_liquid_class` and :py:meth:`.InstrumentContext.consolidate_with_liquid_class` methods, see :ref:`v2-complex-commands`. | |
This section covers selecting a liquid class and using the :py:meth:`~.InstrumentContext.transfer_with_liquid_class` method. For more details, including using the :py:meth:`~.InstrumentContext.distribute_with_liquid_class` and :py:meth:`~.InstrumentContext.consolidate_with_liquid_class` methods, see :ref:`v2-complex-commands`. |
api/docs/v2/robot_position.rst
Outdated
@@ -62,7 +62,7 @@ This is a good position for :ref:`aspirating liquid <new-aspirate>` or an activi | |||
|
|||
.. warning:: | |||
|
|||
Negative ``z`` arguments to ``Well.bottom()`` will cause the pipette tip to collide with the bottom of the well. Collisions may bend the tip (affecting liquid handling) and the pipette may be higher than expected on the z-axis until it picks up another tip. | |||
Negative ``z`` arguments to ``Well.bottom()`` will cause the pipette tip to collide with the bottom of the well. Collisions may bend the tip (affecting liquid handling) and the pipette may be higher than expected on the z-axis until it picks up another tip. Use caution when changing the `z` height, including pipetting at a liquid meniscus, especially in reservoir wells. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inclined to leave this out, for a few reasons:
- The problem in EXEC-1637 isn't really new; it's the combination of an existing problem with meniscus-relative pipetting.
- This doesn't really state what the problem is, or a concrete way to mitigate it.
- This section is about
bottom()
, notmeniscus()
.
If we have labware definitions that are causing crashes when moving to Well.bottom(z=1)
, that's a problem and we should call it out. But we can do that after the 8.5 launch.
…entrons into docs-callouts merge chore release latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
Small PR to add a few final docs callouts before the 8.5 release:
transfer_with_liquid_class()
. @sanni-t pointed out that users might not know where to find this kind of detail.Test Plan and Hands on Testing
http://sandbox.docs.opentrons.com/docs-callouts/v2/
both small changes build with no issues
Changelog
Review requests
Is this sufficient for EXEC-1637? @caila-marashaj and I discussed keeping this simple, including leaving it at all reservoirs, for extra caution. fix for this should be in 8.6.
Risk assessment
low.