Skip to content

final docs callouts #18843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025
Merged

final docs callouts #18843

merged 3 commits into from
Jul 8, 2025

Conversation

emilyburghardt
Copy link
Collaborator

@emilyburghardt emilyburghardt commented Jul 7, 2025

Overview

Small PR to add a few final docs callouts before the 8.5 release:

  1. adding a link to the complex commands section of the API docs when describing for the first time how to use transfer_with_liquid_class(). @sanni-t pointed out that users might not know where to find this kind of detail.
  2. updating our well bottom warning for EXEC-1637.

Test Plan and Hands on Testing

http://sandbox.docs.opentrons.com/docs-callouts/v2/

both small changes build with no issues

Changelog

Review requests

Is this sufficient for EXEC-1637? @caila-marashaj and I discussed keeping this simple, including leaving it at all reservoirs, for extra caution. fix for this should be in 8.6.

Risk assessment

low.

@emilyburghardt emilyburghardt requested a review from a team as a code owner July 7, 2025 21:08
Copy link
Contributor

@caila-marashaj caila-marashaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments. We should be on track to merge this today and tag docs@2.24.

@@ -128,6 +128,8 @@ Using Liquid Classes

You'll use a :ref:`liquid class definition <liquid-class-definitions>` in your protocol to optimize transfer behavior based on liquid properties, along with your chosen Flex pipettes and tips.

This section covers selecting a liquid class and using the :py:meth:`.InstrumentContext.transfer_with_liquid_class` method. For more details, including using the :py:meth:`.InstrumentContext.distribute_with_liquid_class` and :py:meth:`.InstrumentContext.consolidate_with_liquid_class` methods, see :ref:`v2-complex-commands`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full names here make the paragraph wrap in a way that's hard to read. Let's use the shortened versions.

Suggested change
This section covers selecting a liquid class and using the :py:meth:`.InstrumentContext.transfer_with_liquid_class` method. For more details, including using the :py:meth:`.InstrumentContext.distribute_with_liquid_class` and :py:meth:`.InstrumentContext.consolidate_with_liquid_class` methods, see :ref:`v2-complex-commands`.
This section covers selecting a liquid class and using the :py:meth:`~.InstrumentContext.transfer_with_liquid_class` method. For more details, including using the :py:meth:`~.InstrumentContext.distribute_with_liquid_class` and :py:meth:`~.InstrumentContext.consolidate_with_liquid_class` methods, see :ref:`v2-complex-commands`.

@@ -62,7 +62,7 @@ This is a good position for :ref:`aspirating liquid <new-aspirate>` or an activi

.. warning::

Negative ``z`` arguments to ``Well.bottom()`` will cause the pipette tip to collide with the bottom of the well. Collisions may bend the tip (affecting liquid handling) and the pipette may be higher than expected on the z-axis until it picks up another tip.
Negative ``z`` arguments to ``Well.bottom()`` will cause the pipette tip to collide with the bottom of the well. Collisions may bend the tip (affecting liquid handling) and the pipette may be higher than expected on the z-axis until it picks up another tip. Use caution when changing the `z` height, including pipetting at a liquid meniscus, especially in reservoir wells.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to leave this out, for a few reasons:

  1. The problem in EXEC-1637 isn't really new; it's the combination of an existing problem with meniscus-relative pipetting.
  2. This doesn't really state what the problem is, or a concrete way to mitigate it.
  3. This section is about bottom(), not meniscus().

If we have labware definitions that are causing crashes when moving to Well.bottom(z=1), that's a problem and we should call it out. But we can do that after the 8.5 launch.

Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@emilyburghardt emilyburghardt merged commit 9efbc96 into chore_release-8.5.0 Jul 8, 2025
23 checks passed
@emilyburghardt emilyburghardt deleted the docs-callouts branch July 8, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants