Skip to content

fix(protocol-designer): use pre-LC default tip position for non-LC transfers #18849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

ncdiehl11
Copy link
Collaborator

Overview

This PR uses the old default tip offset from bottom (1mm) rather than the water liquid class values for aspirate/dispense tip positioning in non-liquid class transfers.

Closes RQA-4150

Test Plan and Hands on Testing

  • create or upload a protocol to PD
  • create a new transfer step with "Don't use a liquid class" selected
  • verify that aspirate and dispense tip positions are 1mm above bottom rather than 2mm above bottom

Changelog

  • override aspirate/dispense tip position for non-liquid class transfers to pre-LC default (1mm)

Review requests

see test plan

Risk assessment

low

…ansfers

This PR uses the old default tip offset from bottom (1mm) rather than the water liquid class values for aspirate/dispense tip positioning in non-liquid class transfers.

Closes RQA-4150
@ncdiehl11 ncdiehl11 requested review from koji, alexjoel42 and jerader July 8, 2025 14:49
@ncdiehl11 ncdiehl11 marked this pull request as ready for review July 8, 2025 14:49
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner July 8, 2025 14:49
@ncdiehl11 ncdiehl11 self-assigned this Jul 8, 2025
@ncdiehl11 ncdiehl11 removed the request for review from a team July 8, 2025 14:49
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.62%. Comparing base (0f51ada) to head (22107b6).
Report is 3 commits behind head on chore_release-pd-8.5.0.

Files with missing lines Patch % Lines
...r/src/steplist/formLevel/handleFormChange/utils.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           chore_release-pd-8.5.0   #18849      +/-   ##
==========================================================
- Coverage                   24.62%   24.62%   -0.01%     
==========================================================
  Files                        3263     3263              
  Lines                      282677   282678       +1     
  Branches                    30248    30247       -1     
==========================================================
  Hits                        69601    69601              
- Misses                     213056   213057       +1     
  Partials                       20       20              
Flag Coverage Δ
protocol-designer 19.11% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...r/src/steplist/formLevel/handleFormChange/utils.ts 17.61% <0.00%> (-0.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason why we are doing this is because we want to retain old behavior when you aren't using a liquid class?

@ncdiehl11
Copy link
Collaborator Author

the reason why we are doing this is because we want to retain old behavior when you aren't using a liquid class?

correct

@ncdiehl11 ncdiehl11 merged commit e4ab7b3 into chore_release-pd-8.5.0 Jul 8, 2025
21 of 22 checks passed
@ncdiehl11 ncdiehl11 deleted the pd_fix-default-tip-location branch July 8, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants