fix(protocol-designer): align the overflow menus types the same over … #18852
Conversation
| @@ -25,11 +25,6 @@ export function AddStepOverflowButton( | |||
| ): JSX.Element { | |||
| const { onClick, stepType, isFirstStep = false, isLastStep = false } = props | |||
| const { t, i18n } = useTranslation(['tooltip', 'application']) | |||
| // TODO(ja): add or delete tooltips when designs are finalized | |||
There was a problem hiding this comment.
this is a left over TODO from October last year that we don't need
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.5.0 #18852 +/- ##
==========================================================
+ Coverage 24.62% 24.64% +0.02%
==========================================================
Files 3263 3263
Lines 282677 282927 +250
Branches 30248 30313 +65
==========================================================
+ Hits 69601 69737 +136
- Misses 213056 213170 +114
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| @@ -205,7 +205,7 @@ export const OFFDECK: 'offDeck' = 'offDeck' | |||
| export const PROTOCOL_DESIGNER_SOURCE: 'Protocol Designer' = 'Protocol Designer' // protocolSource for tracking analytics in the app | |||
|
|
|||
| export const DECK_SETUP_TOOLS_WIDTH_REM = 21.875 | |||
| export const OVERFLOW_MENU_POSITION_ADJUSTMENT = 4 | |||
| export const OVERFLOW_MENU_POSITION_ADJUSTMENT = 8 | |||
There was a problem hiding this comment.
nit maybe add the units here
There was a problem hiding this comment.
we only add the px on one occasion so i think its easier without adding px
|
Is this "Add step" menu positioning accurate? 
|
@ncdiehl11 |
ah i was changing the timeline width but didn't run into this issue - weird. i guess i need the dynamic width value that the other 2 overflow menus use |
|
Still noticing that the "Add step" overflow menu is positioned inside the toolbox. Is this acceptable? If so I can approve! 
|
can you explain how you got to that state @ncdiehl11? i tried smoke testing at different toolbox widths and never saw that 😢 |
|
the overflow menu is still overlapping with the Add Step button, regardless of the timeline toolbox width. liquids button looks good.
|
@koji thanks, no idea why my end wasn't reflecting that. i just reverted the logic back to how it is in the release branch for this button because design never mentioned it specifically being wrong lol. idk why on my end, it was looking okay. |
to be honest, i'm also not sure what the issue is. i tested your branch locally (make -C protocol-designer dev) worked as expected |
…timeline
closes RQA-4339
Overview
Check overflow menu alignment between the 3 overflow menu types - they should all be the same and match designs
Test Plan and Hands on Testing
Review the screenshots and code and it should match designs
Changelog
Risk assessment
low