-
Notifications
You must be signed in to change notification settings - Fork 183
docs: Flex manual, update E-stop and module behavior table #18857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes to the table that describes how modules react when the e-stop is engaged. Adds new rows for the HEPA/UV module and plate reader. Removes single bullet item lists (might be an artifact from conversion to mkdocs). Replaces markdown w/ html for the table.
Manual says flex status light turns red. It does not. The light turns yellow, solid (not flashing or pulsing). Stays yellow until you reset the e-stop. Last minute change from checking.
Needed a last minute push re: status light info. Will change to regular PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18857 +/- ##
=======================================
Coverage 24.34% 24.34%
=======================================
Files 3312 3312
Lines 289304 289304
Branches 30805 30805
=======================================
Hits 70432 70432
Misses 218851 218851
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to HTML table is a warranted improvement here. A couple prose comments and questions.
Thanks for the suggestions. Applying now. Co-authored-by: Ed Cormany <edward.cormany@opentrons.com>
Thermocycler light turns red, not yellow.
Changes to the table that describes how modules react when the e-stop is engaged. Adds new rows for the HEPA/UV module and plate reader. Removes single bullet item lists (might be an artifact from conversion to mkdocs). Replaces markdown w/ html for the table.
Manual says flex status light turns red. It does not. The light turns yellow, solid (not flashing or pulsing). Stays yellow until you reset the e-stop. Last minute change from checking.
Thanks for the suggestions. Applying now. Co-authored-by: Ed Cormany <edward.cormany@opentrons.com>
Thermocycler light turns red, not yellow.
b0579e9
to
35c5ed4
Compare
…pentrons into estop-docs-revisions
Overview
Revisions to chapter 3, System Description, Emergency Stop Pendant section. Changes update the table that lists how different modules respond to E-stop activation:
JIRA RTC-580
Test Plan and Hands on Testing
Checked with SMEs and testing the robot and e-stop itself.
Changelog
Text changes to a table, contents and code.
Review requests
The usual process.
Risk assessment
Low.