Skip to content

feat(app): add liquid classes values function #18860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: edge
Choose a base branch
from

Conversation

koji
Copy link
Contributor

@koji koji commented Jul 9, 2025

Overview

adding functions to get liquid classes values (replicate PD's implementation) and activate Reset buttons for Aspirate/Dispense.

fyi
from the default value, a few screen's keyboards aren't correct(ex delay's keyboard doesn't support decimal point even thougth the default value is a decimal number) and there issue will be resolved by a following pr.

close AUTH-1011 and AUTH-2000

Test Plan and Hands on Testing

  1. create a new quick transfer
    check values are applied to aspirate and dispense
  2. modify the values in aspirate/dispense
  3. reset values in aspirate/dispense
    check the values are reset

Changelog

  • add a new util to retrieve liquid class values and add a boolean to QuickTransferSummaryState to handle apply the liquid class values to aspirate and dispense.

Review requests

Risk assessment

mid

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 538 lines in your changes missing coverage. Please review.

Project coverage is 27.87%. Comparing base (fe37979) to head (af4fc19).
Report is 35 commits behind head on edge.

Files with missing lines Patch % Lines
...ickTransferFlow/utils/retrieveLiquidClassValues.ts 0.00% 318 Missing ⚠️
...erFlow/utils/getTransferPlanAndReferenceVolumes.ts 0.00% 178 Missing ⚠️
...ferAdvancedSettings/ResetAdvancedSettingsModal.tsx 0.00% 15 Missing ⚠️
...nisms/ODD/QuickTransferFlow/SummaryAndSettings.tsx 0.00% 13 Missing ⚠️
...pp/src/organisms/ODD/QuickTransferFlow/reducers.ts 0.00% 6 Missing ⚠️
...organisms/ODD/QuickTransferFlow/Aspirate/index.tsx 0.00% 2 Missing ⚠️
...organisms/ODD/QuickTransferFlow/Dispense/index.tsx 0.00% 2 Missing ⚠️
...r/src/steplist/formLevel/handleFormChange/utils.ts 0.00% 2 Missing ⚠️
...p/src/organisms/ODD/QuickTransferFlow/constants.ts 0.00% 1 Missing ⚠️
.../QuickTransferFlow/utils/getInitialSummaryState.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #18860       +/-   ##
===========================================
- Coverage   62.73%   27.87%   -34.86%     
===========================================
  Files        3253     3276       +23     
  Lines      257824   261507     +3683     
  Branches    32717    32691       -26     
===========================================
- Hits       161742    72892    -88850     
- Misses      95884   188592    +92708     
+ Partials      198       23      -175     
Flag Coverage Δ
app 3.08% <0.00%> (-44.79%) ⬇️
protocol-designer 18.93% <0.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...anisms/ODD/QuickTransferFlow/SelectLiquidClass.tsx 0.00% <ø> (-97.78%) ⬇️
app/src/organisms/ODD/QuickTransferFlow/types.ts 100.00% <ø> (ø)
...src/organisms/ODD/QuickTransferFlow/utils/index.ts 0.00% <ø> (-100.00%) ⬇️
...p/src/organisms/ODD/QuickTransferFlow/constants.ts 0.00% <0.00%> (-96.24%) ⬇️
.../QuickTransferFlow/utils/getInitialSummaryState.ts 0.00% <0.00%> (-76.00%) ⬇️
...organisms/ODD/QuickTransferFlow/Aspirate/index.tsx 0.00% <0.00%> (-85.08%) ⬇️
...organisms/ODD/QuickTransferFlow/Dispense/index.tsx 0.00% <0.00%> (-81.82%) ⬇️
...r/src/steplist/formLevel/handleFormChange/utils.ts 15.01% <0.00%> (-3.76%) ⬇️
...pp/src/organisms/ODD/QuickTransferFlow/reducers.ts 0.00% <0.00%> (-1.10%) ⬇️
...nisms/ODD/QuickTransferFlow/SummaryAndSettings.tsx 0.00% <0.00%> (-58.34%) ⬇️
... and 3 more

... and 1680 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji requested review from ncdiehl11 and jerader July 9, 2025 22:32
@koji koji marked this pull request as ready for review July 9, 2025 22:43
@koji koji changed the title feat(app): Feat liquid classes value function feat(app): add liquid classes values function Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant