Skip to content

Merge back 'chore_release-pd-8.5.0' into 'edge' #18861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 9, 2025
Merged

Conversation

ddcc4
Copy link
Collaborator

@ddcc4 ddcc4 commented Jul 9, 2025

This picks up the changes to chore_release-8.5.0 and chore_release-pd-8.5.0 we made this week, including the final fixes for the RS 8.5.0 release.

emilyburghardt and others added 10 commits July 3, 2025 15:57
<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:


https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview

Liquid classes in API 2.24. Includes new articles covering liquid
classes and liquid class definitions, plus changes throughout our
Complex Commands section.


<!--
Describe your PR at a high level. State acceptance criteria and how this
PR fits into other work. Link issues, PRs, and other relevant resources.
-->

## Test Plan and Hands on Testing

<!--
Describe your testing of the PR. Emphasize testing not reflected in the
code. Attach protocols, logs, screenshots and any other assets that
support your testing.
-->

## Changelog
-brought over liquid classes text from [PR
#17992](https://github.com/Opentrons/opentrons/pull/17992/files#diff-0f90fc8fd15163b9fb8b128ac3c358036fbb7bef07c549fbdbec8b45cb26af51)
- reorganized the liquid classes article to ease into property
descriptions
- build issues with images in the properties table; currently in the
docs as a list to avoid this.
- adding custom liquid class creator section (and differentiate between
customizing and *creating* from scratch)
- built out liquid class definition tables section 
- updated API reference for tip handling options, `get_liquid_class` and
`define_liquid_class` entries
- linked users to github schema for creating their own liquid class 

<!--
List changes introduced by this PR considering future developers and the
end user. Give careful thought and clear documentation to breaking
changes.
-->

## Review requests

<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

## Risk assessment

<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->

---------

Co-authored-by: Edward Cormany <edward.cormany@opentrons.com>
…se more than tip liquid volume (#18844)

# Overview

Without the change in this PR, if an attempt is made to dispense more
than the volume present in tip, an obscure error saying `'Value must be
a positive float.'`. This error stems from the `dispense_and_wait`
method when trying to find the correction volume for a negative volume
found by calculating tip volume after dispense as `current_tip_vol -
dispense_vol`.

This PR adds a quick check for tip volume and raises an informative
error to the user.

## Risk assessment

None. Only adds an error message.
…ansfers (#18849)

This PR uses the old default tip offset from bottom (1mm) rather than
the water liquid class values for aspirate/dispense tip positioning in
non-liquid class transfers.

Closes RQA-4150
<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:


https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview

Small PR to add a few final docs callouts before the 8.5 release:
1) adding a link to the [complex
commands](file:///Users/emilyburghardt/opentrons/api/docs/build/html/v2/new_complex_commands.html)
section of the API docs when describing for the first time how to use
`transfer_with_liquid_class()`. @sanni-t pointed out that users might
not know where to find this kind of detail.
2) updating our well bottom warning for
[EXEC-1637](https://opentrons.atlassian.net/jira/software/c/projects/EXEC/issues/EXEC-1637?jql=project%20%3D%20%22EXEC%22%20ORDER%20BY%20created%20DESC).
<!--
Describe your PR at a high level. State acceptance criteria and how this
PR fits into other work. Link issues, PRs, and other relevant resources.
-->

## Test Plan and Hands on Testing

<!--
Describe your testing of the PR. Emphasize testing not reflected in the
code. Attach protocols, logs, screenshots and any other assets that
support your testing.
-->

http://sandbox.docs.opentrons.com/docs-callouts/v2/  

both small changes build with no issues

## Changelog

<!--
List changes introduced by this PR considering future developers and the
end user. Give careful thought and clear documentation to breaking
changes.
-->

## Review requests

<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

Is this sufficient for
[EXEC-1637](https://opentrons.atlassian.net/jira/software/c/projects/EXEC/issues/EXEC-1637?jql=project%20%3D%20%22EXEC%22%20ORDER%20BY%20created%20DESC)?
@caila-marashaj and I discussed keeping this simple, including leaving
it at _all reservoirs_, for extra caution. fix for this should be in
8.6.

## Risk assessment
low. 
<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->

[EXEC-1637]:
https://opentrons.atlassian.net/browse/EXEC-1637?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This PR ensures that the interpolated liquid class flow rate for
aspirate, dispense, and blowout does not exceed the range prescribed by
the pipette liquid definition's plunger curves. To achieve this, we
reuse the max flow rate logic in `getMaxUiFlowRate` in the liquid class
form change handler utils, to make sure the populated flow rates from
the liquid class are physically possible.

The code is a bit redundant in the various form change utils, but I am
erring on the side of caution vs. DRY given the upcoming release. I can
refactor the utilities in a followup post-release.

Closes RQA-4151
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 2.63158% with 37 lines in your changes missing coverage. Please review.

Project coverage is 24.34%. Comparing base (011870e) to head (eb6823b).
Report is 658 commits behind head on edge.

Files with missing lines Patch % Lines
.prettierrc.js 0.00% 22 Missing ⚠️
.storybook/preview.tsx 0.00% 9 Missing ⚠️
.storybook/main.ts 0.00% 4 Missing ⚠️
__mocks__/electron-updater.js 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18861      +/-   ##
==========================================
+ Coverage   24.08%   24.34%   +0.26%     
==========================================
  Files        3265     3312      +47     
  Lines      282662   289304    +6642     
  Branches    29924    30805     +881     
==========================================
+ Hits        68079    70432    +2353     
- Misses     214558   218851    +4293     
+ Partials       25       21       -4     
Flag Coverage Δ
protocol-designer 19.11% <0.00%> (+0.41%) ⬆️
step-generation 5.33% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
__mocks__/electron-store.js 67.85% <100.00%> (+67.85%) ⬆️
app-shell-odd/src/actions.ts 16.96% <ø> (+16.96%) ⬆️
app-shell-odd/src/config/index.ts 18.91% <ø> (+18.91%) ⬆️
app-shell-odd/src/config/migrate.ts 87.08% <ø> (+87.08%) ⬆️
app-shell-odd/src/config/update.ts 83.78% <ø> (+83.78%) ⬆️
app-shell-odd/src/constants.ts 100.00% <ø> (+99.23%) ⬆️
app-shell-odd/src/dialogs/index.ts 72.22% <ø> (+72.22%) ⬆️
app-shell-odd/src/discovery.ts 79.19% <ø> (+79.19%) ⬆️
app-shell-odd/src/early.ts 66.66% <ø> (+66.66%) ⬆️
app-shell-odd/src/http.ts 31.81% <ø> (+31.81%) ⬆️
... and 35 more

... and 786 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jbleon95 jbleon95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python changes look good

@ddcc4 ddcc4 merged commit 026eba7 into edge Jul 9, 2025
35 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants