Skip to content

fix(shared-data): Mark absorbanceReaderV1 and flexStackerModuleV1 as incompatible with OT-2 #18873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Jul 10, 2025

Overview

This makes some small, academic corrections to module definitions. I doubt this actually affects anything user-facing, but if the data is there, it ought to be correct.

Test Plan and Hands on Testing

Just automated tests.

Changelog

  • Mark flexStackerModuleV1 as incompatible with the OT-2 in its module definition.
  • Delete some OT-2 specific transforms from flexStackerModuleV1. They weren't doing anything because that module can't be placed on an OT-2 deck anyway.
  • Mark absorbanceReaderV1 as incompatible with ot2_standard and ot2_short_trash, not just ot2_standard.

Review requests

None in particular.

Risk assessment

Low.

@SyntaxColoring SyntaxColoring requested review from a team as code owners July 10, 2025 14:14
@SyntaxColoring SyntaxColoring requested review from ncdiehl11 and removed request for a team July 10, 2025 14:14
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.82%. Comparing base (9964abd) to head (3abf51f).
Report is 10 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #18873   +/-   ##
=======================================
  Coverage   23.82%   23.82%           
=======================================
  Files        3329     3329           
  Lines      287227   287227           
  Branches    35927    35927           
=======================================
  Hits        68420    68420           
  Misses     218781   218781           
  Partials       26       26           
Flag Coverage Δ
protocol-designer 19.03% <ø> (ø)
step-generation 5.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SyntaxColoring SyntaxColoring merged commit 41c97ad into edge Jul 11, 2025
87 of 90 checks passed
@SyntaxColoring SyntaxColoring deleted the module_compatibility branch July 11, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants