Skip to content

feat(app): update pushout screen #18894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: edge
Choose a base branch
from
Open

feat(app): update pushout screen #18894

wants to merge 5 commits into from

Conversation

koji
Copy link
Contributor

@koji koji commented Jul 12, 2025

Overview

add push out volume to pushout screen and update QuickTransferSummaryState for pushout volume

close AUTH-2073

Test Plan and Hands on Testing

Changelog

  • update QuickTransferSummaryState
  • update pushout component
  • update pushout tests

Review requests

Risk assessment

low

add push out volume to pushout screen and update state for pushout volumen

close AUTH-2073
@koji koji requested review from ncdiehl11 and jerader July 12, 2025 19:39
@koji koji marked this pull request as ready for review July 12, 2025 19:39
<InputField
type="number"
value={volume}
// error={durationError}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess it is needed so you can get the push out range

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncdiehl11 how do you get push out range? 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-07-14 at 6 31 53 PM

added a util function to get the max volume.

@ncdiehl
I'll work on moving the function to shared-data later.

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments - looks good overall. Would love for @ncdiehl11 to review to double check that this functions the same way as the push out volume in PD. I can't remember if we default push out to 0 when the box is checked or if there is a default value.

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 113 lines in your changes missing coverage. Please review.

Project coverage is 25.38%. Comparing base (1cb77b3) to head (4226703).
Report is 1 commits behind head on edge.

Files with missing lines Patch % Lines
...sferFlow/QuickTransferAdvancedSettings/PushOut.tsx 0.00% 109 Missing ⚠️
...erFlow/Dispense/hooks/useDispenseSettingsConfig.ts 0.00% 2 Missing ⚠️
...pp/src/organisms/ODD/QuickTransferFlow/reducers.ts 0.00% 1 Missing ⚠️
.../QuickTransferFlow/utils/getInitialSummaryState.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18894      +/-   ##
==========================================
- Coverage   25.38%   25.38%   -0.01%     
==========================================
  Files        3333     3333              
  Lines      287696   287768      +72     
  Branches    36490    36488       -2     
==========================================
  Hits        73040    73040              
- Misses     214633   214705      +72     
  Partials       23       23              
Flag Coverage Δ
protocol-designer 18.99% <0.00%> (-0.01%) ⬇️
step-generation 5.31% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/src/organisms/ODD/QuickTransferFlow/types.ts 100.00% <ø> (ø)
...pp/src/organisms/ODD/QuickTransferFlow/reducers.ts 0.00% <0.00%> (ø)
.../QuickTransferFlow/utils/getInitialSummaryState.ts 0.00% <0.00%> (ø)
...erFlow/Dispense/hooks/useDispenseSettingsConfig.ts 0.00% <0.00%> (ø)
...sferFlow/QuickTransferAdvancedSettings/PushOut.tsx 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji requested a review from jerader July 14, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants