-
Notifications
You must be signed in to change notification settings - Fork 183
feat(app): update pushout screen #18894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: edge
Are you sure you want to change the base?
Conversation
add push out volume to pushout screen and update state for pushout volumen close AUTH-2073
app/src/organisms/ODD/QuickTransferFlow/QuickTransferAdvancedSettings/PushOut.tsx
Outdated
Show resolved
Hide resolved
<InputField | ||
type="number" | ||
value={volume} | ||
// error={durationError} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess it is needed so you can get the push out range
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ncdiehl11 how do you get push out range? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

added a util function to get the max volume.
@ncdiehl
I'll work on moving the function to shared-data
later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments - looks good overall. Would love for @ncdiehl11 to review to double check that this functions the same way as the push out volume in PD. I can't remember if we default push out to 0 when the box is checked or if there is a default value.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18894 +/- ##
==========================================
- Coverage 25.38% 25.38% -0.01%
==========================================
Files 3333 3333
Lines 287696 287768 +72
Branches 36490 36488 -2
==========================================
Hits 73040 73040
- Misses 214633 214705 +72
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Overview
add push out volume to pushout screen and update QuickTransferSummaryState for pushout volume
close AUTH-2073
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low