Add board Luckfox Nova W #8306
Add board Luckfox Nova W #8306
Conversation
nikvoid
requested review from
NicoD-SBC,
SuperKali,
TheSnowfield,
Tonymac32,
amazingfate,
catalinii,
igorpecovnik,
pyavitz and
rpardini
as code owners
|
""" WalkthroughThis change introduces support for the Luckfox Nova W board, based on the Rockchip RK3308B SoC. It adds a dedicated board configuration file specifying build parameters, kernel source, bootloader, firmware, and runtime tweaks for this device. A new U-Boot boot script targeting Rockchip64 devices with the ttyS4 serial console is included, handling environment setup, device tree overlays, and kernel booting logic. Additionally, a comprehensive Linux kernel configuration tailored for the RK3308 platform is provided, enabling a wide array of features such as networking, storage, power management, debugging, and Rockchip-specific drivers and options. Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
size/large
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (3)
config/bootscripts/boot-rockchip64-ttyS4.cmd (1)
62-66: Overlay restore path leavesoverlay_errorset to trueAfter restoring the original DT,
overlay_erroris left unchanged. Subsequent logic or scripts that inspect this variable will still think an overlay error is active.-load ${devtype} ${devnum}:${distro_bootpart} ${fdt_addr_r} ${prefix}dtb/${fdtfile} +load ${devtype} ${devnum}:${distro_bootpart} ${fdt_addr_r} ${prefix}dtb/${fdtfile} +setenv overlay_error "false"config/boards/luckfox-nova-w.csc (1)
53-55:mvmay abort if the firmware path does not existOn early images the upper-case directory might already be in lower-case form,
causingmvto fail and abort the whole build script.-mv "${SDCARD}/lib/firmware/aic8800/SDIO/aic8800DC" "${SDCARD}/lib/firmware/aic8800/SDIO/aic8800dc" +mv -f "${SDCARD}/lib/firmware/aic8800/SDIO/aic8800DC" \ + "${SDCARD}/lib/firmware/aic8800/SDIO/aic8800dc" 2>/dev/null || trueconfig/kernel/linux-luckfox-nova-w-rk3308-vendor.config (1)
465-488: Heavy debug & tracing options will waste scarce 512 MB DRAM
CONFIG_DYNAMIC_DEBUG,FTRACE,DEBUG_INFO_*,PROVE_LOCKING, full
PREEMPT,HZ_1000, etc. are all enabled. Great for bring-up, but they cost
both memory (≈ 40-60 MB extra) and performance on a tiny Cortex-A35.Consider shipping two defconfigs:
• debug (current), and
• production with
CONFIG_PREEMPT_VOLUNTARYCONFIG_HZ_250# CONFIG_DYNAMIC_DEBUG is not set# CONFIG_DEBUG_INFO_* is not set# CONFIG_FUNCTION_TRACER is not setThis drops idle RAM usage by ~10 % on RK3308.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
patch/kernel/rockchip64-vendor-6.1/0000.patching_config.yamlis excluded by!patch/**patch/kernel/rockchip64-vendor-6.1/aic8800-select-rk-platform.patchis excluded by!patch/**patch/kernel/rockchip64-vendor-6.1/dt/rk3308-luckfox-nova-w.dtsis excluded by!patch/**patch/kernel/rockchip64-vendor-6.1/qcaspi-rkspi-fix.patchis excluded by!patch/**patch/kernel/rockchip64-vendor-6.1/rfkill-rk-sdio-rescan.patchis excluded by!patch/**patch/kernel/rockchip64-vendor-6.1/usbotg-fix.patchis excluded by!patch/**patch/u-boot/v2025.04/board_luckfox-nova-w/add-board-luckfox-nova-w-rk3308b.patchis excluded by!patch/**
📒 Files selected for processing (3)
config/boards/luckfox-nova-w.csc(1 hunks)config/bootscripts/boot-rockchip64-ttyS4.cmd(1 hunks)config/kernel/linux-luckfox-nova-w-rk3308-vendor.config(1 hunks)
🔇 Additional comments (1)
config/bootscripts/boot-rockchip64-ttyS4.cmd (1)
37-41:rootdevremains a hard-coded/dev/mmcblk0p1whilepartuuidis resolvedYou correctly detect the partition UUID (line 38) but do not use it.
Using the device node in one place and PARTUUID in another breaks when
/dev/mmcblk0numbering changes (USB-boot, NVMe, different eMMC order, etc.).-setenv rootdev "/dev/mmcblk0p1" +setenv rootdev "PARTUUID=${partuuid}"Alternatively keep
rootdevdefault and replace${rootdev}with
PARTUUID=${partuuid}directly inbootargs.
github-actions
bot
removed
the
Ready to merge
There was a problem hiding this comment.
Please note that these patches must not break existing hardware support, and it's best to submit them to this repository: https://github.com/armbian/linux-rockchip.
There was a problem hiding this comment.
I know, but they may break, and now this is a single board with these patches
| # eMMC works properly only in vendor branch | ||
| KERNEL_TARGET="vendor" | ||
|
|
||
| KERNELSOURCE='https://github.com/armbian/linux-rockchip.git' |
There was a problem hiding this comment.
I suggest referring to other RK3308-based devices, and ideally using the mainline kernel.
There was a problem hiding this comment.
Agreed. AFAIR rk bsp is mostly designed to support rk35xx family, not sure how much work has been done for rk33xx. Though most of if is mainlined and this shall be preferred.
There was a problem hiding this comment.
I could not get emmc working in mainline kernels. May be I'll revisit this later to derive patches
There was a problem hiding this comment.
Please ensure this patch does not break aic8800 support on other Rockchip devices.
There was a problem hiding this comment.
Maybe just make patches board-specific to be sure? Could you say how to do that?
| @@ -0,0 +1,55 @@ | |||
| # Rockchip RK3308B quad core 512MB SoC WiFi | |||
| # https://www.luckfox.com/Luckfox-Nova | |||
| BOOT_SOC="rk3308" | ||
| BOOTCONFIG="luckfox-nova-w_rk3308b_defconfig" | ||
| BOOT_FDT_FILE="rockchip/rk3308-luckfox-nova-w.dtb" | ||
|
|
There was a problem hiding this comment.
Remove empty lines where they don't make sense
| # eMMC works properly only in vendor branch | ||
| KERNEL_TARGET="vendor" | ||
|
|
||
| KERNELSOURCE='https://github.com/armbian/linux-rockchip.git' |
There was a problem hiding this comment.
Agreed. AFAIR rk bsp is mostly designed to support rk35xx family, not sure how much work has been done for rk33xx. Though most of if is mainlined and this shall be preferred.
Description
Add initial support for board Luckfox Nova W.
Luckfox Nova W is recently produced board on SoC Rockchip RK3308B: 4 x Cortex-A35 CPU, 512 RAM, 8 GB eMMC.
It also has Ethernet, WIFI & BT, USB-A and USB-C ports, soldered microphone.
Product page: https://www.luckfox.com/Luckfox-Nova?ci=646
But beware: it is very fresh board, has almost no documentation and only buildroot SDK with kernel 5.10 is available from vendor.
Documentation
I decided to create separate directory for vendor kernel patches. This kernel must be the same as
rk35xx-vendor-6.1, but this SoC is not RK35XX.Used U-Boot is mainline.
Instead of DKMS AIC8800 driver I enabled the one from kernel sources, because I needed to apply patches to it. And image builds faster than with DKMS.
UART4 is used for serial console and by proprietary firmware blobs.
How Has This Been Tested?
currentandedgerk6.1Checklist:
Please delete options that are not relevant.