linux-uefi-arm64-cloud.config: enable ACPI so things boot #8377
Conversation
WalkthroughThe kernel configuration file for linux-uefi-arm64-cloud was extensively revised. Numerous features were disabled, including SMP, hypervisor guest support, paravirtualization, NUMA, and cloud-specific virtualization drivers for AWS and Azure. EFI support options were removed. The updated configuration enables inter-process communication, BPF, debugging, expanded control groups, and namespace support. Virtualization drivers were consolidated, and networking features such as netfilter, nftables, IPVS, VLAN, and WireGuard were enabled. Filesystem and security options were broadened, with SELinux, AppArmor, and encrypted keys now included. Sound, USB, input, and hardware random number generator options were retained or enhanced. Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
08
coderabbitai
bot
added
05
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
config/kernel/linux-uefi-arm64-cloud.config (1)
255-256: DWARF5 + BTF debug info balloons image size
CONFIG_DEBUG_INFO_DWARF5=y&CONFIG_DEBUG_INFO_BTF=yroughly double build time and can add ≈ 200 MB tovmlinux/modules.*.
For distro kernels that never ship the unstripped images, consider:-CONFIG_DEBUG_INFO_DWARF5=y -CONFIG_DEBUG_INFO_BTF=y +# CONFIG_DEBUG_INFO_DWARF5 is not set +# CONFIG_DEBUG_INFO_BTF is not setUnless you explicitly need CO-RE/BPF or full DWARF5 in cloud builds.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/kernel/linux-uefi-arm64-cloud.config(4 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: EvilOlaf
PR: armbian/build#8328
File: lib/functions/compilation/patch/drivers_network.sh:542-545
Timestamp: 2025-06-24T10:08:40.313Z
Learning: In the Armbian build system, when a PR removes build support for a specific kernel version, version check issues for that removed version become practically irrelevant even if they appear incorrect in isolation. Context about which kernel versions are being deprecated/removed is important for understanding the impact of version-related code changes.
Learnt from: libiunc
PR: armbian/build#8033
File: config/kernel/linux-starfive2-vendor.config:43-43
Timestamp: 2025-03-31T12:57:13.880Z
Learning: For StarFive2 platform kernel configurations, maintain alignment with vendor-provided configurations rather than modifying security settings like SECCOMP. This ensures hardware compatibility as intended by the manufacturer.
Learnt from: pyavitz
PR: armbian/build#8361
File: config/kernel/linux-sunxi64-edge.config:594-597
Timestamp: 2025-07-06T16:27:45.349Z
Learning: In Armbian sunxi64-edge kernel configurations, PCI/PCIe support may be enabled for future-proofing purposes to support upcoming Allwinner SoCs like the T536 that include PCIe Gen2 interfaces, even if current primary targets like H616 lack PCIe controllers. This forward-looking approach prepares the configuration for next-generation hardware in the same SoC family.
Learnt from: EvilOlaf
PR: armbian/build#0
File: :0-0
Timestamp: 2025-06-16T03:24:00.458Z
Learning: In Armbian board configuration files (.csc), the standard pattern is to have only one line as a comment describing the board hardware specifications. This single-line description typically includes the SoC model, core count, RAM options, and key features like connectivity options, storage interfaces, and special features.
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:42:09.086Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, KERNELSOURCE is explicitly declared when using unofficial or 3rd party kernel repositories (like the "dev" branch using https://github.com/apritzel/linux), but can be omitted when using the standard mainline kernel (like the "edge" branch) since it will fall back to the default mainline source.
Learnt from: Grippy98
PR: armbian/build#8152
File: lib/functions/configuration/interactive.sh:209-266
Timestamp: 2025-05-05T12:35:07.143Z
Learning: For the interactive kernel selection in Armbian, KERNEL_MAJOR_MINOR and KERNEL_DESCRIPTION are parsed from family.conf but deliberately not set as environment variables to avoid potential interference with other parts of the build system.
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:40:52.109Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, when KERNELSOURCE is not explicitly declared in a case branch, the system falls back to a default KERNELSOURCE value, so missing KERNELSOURCE declarations are not critical issues.
config/kernel/linux-uefi-arm64-cloud.config (7)
Learnt from: libiunc
PR: armbian/build#8033
File: config/kernel/linux-starfive2-vendor.config:43-43
Timestamp: 2025-03-31T12:57:13.880Z
Learning: For StarFive2 platform kernel configurations, maintain alignment with vendor-provided configurations rather than modifying security settings like SECCOMP. This ensures hardware compatibility as intended by the manufacturer.
Learnt from: pyavitz
PR: armbian/build#8361
File: config/kernel/linux-sunxi64-edge.config:594-597
Timestamp: 2025-07-06T16:27:45.349Z
Learning: In Armbian sunxi64-edge kernel configurations, PCI/PCIe support may be enabled for future-proofing purposes to support upcoming Allwinner SoCs like the T536 that include PCIe Gen2 interfaces, even if current primary targets like H616 lack PCIe controllers. This forward-looking approach prepares the configuration for next-generation hardware in the same SoC family.
Learnt from: EvilOlaf
PR: armbian/build#0
File: :0-0
Timestamp: 2025-06-16T03:24:00.458Z
Learning: In Armbian board configuration files (.csc), the standard pattern is to have only one line as a comment describing the board hardware specifications. This single-line description typically includes the SoC model, core count, RAM options, and key features like connectivity options, storage interfaces, and special features.
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:40:52.109Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, when KERNELSOURCE is not explicitly declared in a case branch, the system falls back to a default KERNELSOURCE value, so missing KERNELSOURCE declarations are not critical issues.
Learnt from: EvilOlaf
PR: armbian/build#8328
File: lib/functions/compilation/patch/drivers_network.sh:542-545
Timestamp: 2025-06-24T10:08:40.313Z
Learning: In the Armbian build system, when a PR removes build support for a specific kernel version, version check issues for that removed version become practically irrelevant even if they appear incorrect in isolation. Context about which kernel versions are being deprecated/removed is important for understanding the impact of version-related code changes.
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:42:09.086Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, KERNELSOURCE is explicitly declared when using unofficial or 3rd party kernel repositories (like the "dev" branch using https://github.com/apritzel/linux), but can be omitted when using the standard mainline kernel (like the "edge" branch) since it will fall back to the default mainline source.
Learnt from: Grippy98
PR: armbian/build#8152
File: lib/functions/configuration/interactive.sh:209-266
Timestamp: 2025-05-05T12:35:07.143Z
Learning: For the interactive kernel selection in Armbian, KERNEL_MAJOR_MINOR and KERNEL_DESCRIPTION are parsed from family.conf but deliberately not set as environment variables to avoid potential interference with other parts of the build system.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Shell script analysis
🔇 Additional comments (2)
config/kernel/linux-uefi-arm64-cloud.config (2)
14-16: IKCONFIG exposed ‒ good callKeeping
CONFIG_IKCONFIG=yandCONFIG_IKCONFIG_PROC=yis handy for later auditing which options shipped in the running kernel. 👍
41-43: ACPI enablement un-blocks UEFI boot path
CONFIG_ACPI=yis the critical bit that was missing for cloud images on arm64-UEFI. This should resolve the early-boot hang you described.
| CONFIG_NETCONSOLE=y | ||
| CONFIG_VETH=m | ||
| CONFIG_VIRTIO_NET=y | ||
| CONFIG_NETKIT=y | ||
| CONFIG_ENA_ETHERNET=y | ||
| CONFIG_E1000E=y |
There was a problem hiding this comment.
CONFIG_NETKIT is not a valid Kconfig symbol
Upstream (v6.10-rc / v6.9) contains no NETKIT. The option will be ignored, but it triggers a warning and pollutes the sanitized config.
-CONFIG_NETKIT=y
+# CONFIG_NETKIT is not set # removed – unknown symbol📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| CONFIG_NETCONSOLE=y | |
| CONFIG_VETH=m | |
| CONFIG_VIRTIO_NET=y | |
| CONFIG_NETKIT=y | |
| CONFIG_ENA_ETHERNET=y | |
| CONFIG_E1000E=y | |
| CONFIG_NETCONSOLE=y | |
| CONFIG_VETH=m | |
| CONFIG_VIRTIO_NET=y | |
| # CONFIG_NETKIT is not set # removed – unknown symbol | |
| CONFIG_ENA_ETHERNET=y | |
| CONFIG_E1000E=y |
🤖 Prompt for AI Agents
In config/kernel/linux-uefi-arm64-cloud.config around lines 165 to 170, the
CONFIG_NETKIT option is invalid and not recognized by the kernel configuration
system, causing warnings and config pollution. Remove the line setting
CONFIG_NETKIT=y to fix the issue and ensure the config only contains valid
Kconfig symbols.
| CONFIG_IP_PIMSM_V1=y | ||
| CONFIG_IP_PIMSM_V2=y | ||
| CONFIG_SYN_COOKIES=y | ||
| CONFIG_INET_ESP=m | ||
| # CONFIG_INET_DIAG is not set | ||
| CONFIG_TCP_CONG_ADVANCED=y |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Re-enable INET_DIAG to avoid breaking iproute2/ss
Disabling INET_DIAG will cripple userspace tools (ss, ss -s, ip -s link, Docker’s network stats, etc.) that rely on the netlink socket-diagnostic family.
-# CONFIG_INET_DIAG is not set
+CONFIG_INET_DIAG=y🏁 Script executed:
#!/bin/bash
# Search for occurrences of CONFIG_INET_DIAG in the repository
grep -R "CONFIG_INET_DIAG" -n .Length of output: 7633
🏁 Script executed:
#!/bin/bash
# List all cloud config files and their CONFIG_INET_DIAG settings
for f in $(find config/kernel -type f -name "*cloud.config"); do
echo "File: $f"
grep -n "CONFIG_INET_DIAG" "$f" || echo " (no CONFIG_INET_DIAG found)"
echo
doneLength of output: 614
Enable INET_DIAG in cloud kernel configs to restore netlink diagnostics
Disabling INET_DIAG in the UEFI cloud variants will break userspace tools (ss, ip -s link, Docker network stats, etc.) that rely on the INET diagnostic family. Please re-enable it in both cloud configs:
• config/kernel/linux-uefi-arm64-cloud.config (line 68)
• config/kernel/linux-uefi-x86-cloud.config (line 142)
Suggested change:
-# CONFIG_INET_DIAG is not set
+CONFIG_INET_DIAG=mOptionally, you may also enable cleanup support:
+# CONFIG_INET_DIAG_DESTROY was not set
+CONFIG_INET_DIAG_DESTROY=y📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| CONFIG_IP_PIMSM_V1=y | |
| CONFIG_IP_PIMSM_V2=y | |
| CONFIG_SYN_COOKIES=y | |
| CONFIG_INET_ESP=m | |
| # CONFIG_INET_DIAG is not set | |
| CONFIG_TCP_CONG_ADVANCED=y | |
| CONFIG_IP_PIMSM_V1=y | |
| CONFIG_IP_PIMSM_V2=y | |
| CONFIG_INET_ESP=m | |
| CONFIG_INET_DIAG=m | |
| # CONFIG_INET_DIAG_DESTROY was not set | |
| CONFIG_INET_DIAG_DESTROY=y | |
| CONFIG_TCP_CONG_ADVANCED=y |
🤖 Prompt for AI Agents
In config/kernel/linux-uefi-arm64-cloud.config around lines 65 to 69, the
INET_DIAG option is disabled, which breaks userspace tools relying on netlink
diagnostics. Re-enable CONFIG_INET_DIAG by removing the comment prefix on line
68 to set it as enabled. Also, apply the same change to
config/kernel/linux-uefi-x86-cloud.config around line 142. Optionally, consider
enabling cleanup support as suggested.
Description
We Need ACPI enabled for uefi-arm64-cloud images to boot successfully. Changes look drastic because I used
./compile.sh kernel-configand it sanitized things.Resolves: not booting and 100% cpu and blank screen.
Pairs will with #8376
Tech debt:
enable_extension image-output-qcow2