-
-
Notifications
You must be signed in to change notification settings - Fork 192
Add CPUTHREADS Build Switch #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe documentation file Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
docs/Developer-Guide_Build-Switches.md (3)
261-261
: Use the correct type hint – this should beinteger
, notstring
.Everywhere else we document numeric build switches as
integer
(e.g.SECTOR_SIZE
). MarkingCPUTHREADS
asstring
is misleading because only a positive integer is valid.-**CPUTHREADS** ( `string` ) +**CPUTHREADS** ( `integer` )
263-265
: Minor grammar & casing fix for the default-value sentence.-If not defined, defaults to 150% the number of CPU Threads available to maximize compilation speed. +If not defined, defaults to 150 % of the number of CPU threads available to maximise compilation speed.
261-266
: Add a short usage example for consistency with neighbouring switches.Most switches in this section provide a concrete
./compile.sh …
snippet; adding one here makes the docs scan-friendly.@@ Allows the user to override CTHREADS if CPUTHREADS is defined and a valid positive integer. If not defined, defaults to 150% of the number of CPU threads available to maximize compilation speed. +Example: + +```sh +./compile.sh CPUTHREADS=8 +```
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/Developer-Guide_Build-Switches.md
(1 hunks)
🔇 Additional comments (1)
docs/Developer-Guide_Build-Switches.md (1)
261-266
: Confirm the variable name matches the implementation.The description states it “overrides CTHREADS”. Please double-check that the build scripts actually read
CPUTHREADS
(and not e.g.CPU_THREADS
orCTHREADS
) to avoid a documentation/implementation drift.
add string values here too |
Documentation to match armbian/build#8346
Documentation website preview will be available shortly:
Open WWW preview