Rust: Update legacy MaD models 2 #19942
Conversation
geoffw0
added
no-change-note-required
|
Accepted test regressions. There are almost no results left for We also lose some results in a test case involving a loop, similar to the one discussed in #19934 (comment) . |
| - ["repo:https://github.com/RustCrypto/traits:digest", "<_ as crate::digest::Digest>::chain_update", "Argument[0]", "hasher-input", "manual"] | ||
| - ["repo:https://github.com/RustCrypto/traits:digest", "<_ as crate::digest::Digest>::digest", "Argument[0]", "hasher-input", "manual"] | ||
| - ["repo:https://github.com/stainless-steel/md5:md5", "crate::compute", "Argument[0]", "hasher-input", "manual"] | ||
| - ["<digest::core_api::wrapper::CoreWrapper as digest::Update>::new_with_prefix", "Argument[0]", "hasher-input", "manual"] |
There was a problem hiding this comment.
This looks a bit strange. The digest::Update trait does not have a new_with_prefix as far as I know. I think it doesn't have chain_update or digest either.
There was a problem hiding this comment.
I'll investigate this...
There was a problem hiding this comment.
In real world (MRVA) projects we mostly don't get a canonical path at all on new_with_prefix, when we do it's something like the above or <_ as digest::digest::Digest>::new_with_prefix. The latter looks better actually, so I've switched to that.
I plan to convert this to a trait model at some point, which will be more robust, but I don't think we (quite) have everything in place for that yet.
| - ["<_ as tokio::io::util::async_read_ext::AsyncReadExt>:::read_f32_le", "Argument[self]", "ReturnValue.Future.Field[core::result::Result::Ok(0)]", "taint", "manual"] | ||
| - ["<_ as tokio::io::util::async_read_ext::AsyncReadExt>::read_f64", "Argument[self]", "ReturnValue.Future.Field[core::result::Result::Ok(0)]", "taint", "manual"] | ||
| - ["<_ as tokio::io::util::async_read_ext::AsyncReadExt>::read_f64_le", "Argument[self]", "ReturnValue.Future.Field[core::result::Result::Ok(0)]", "taint", "manual"] | ||
| - ["<_ as core::iter::traits::iterator::Iterator>::chain", "Argument[self]", "ReturnValue", "taint", "manual"] |
There was a problem hiding this comment.
These probably do not belong in the tokio models anymore.
There was a problem hiding this comment.
I agree, but I'm keen to save moving stuff around for after these four PRs are merged (to prevent merge conflicts and confusing diffs).
I do have an issue tracking this.
Co-authored-by: Arthur Baars <aibaars@github.com>
| - ["<_ as digest::digest::Digest>::new_with_prefix::new_with_prefix", "Argument[0]", "hasher-input", "manual"] | ||
| - ["<_ as digest::digest::Digest>::new_with_prefix::update", "Argument[0]", "hasher-input", "manual"] | ||
| - ["<_ as digest::digest::Digest>::new_with_prefix::chain_update", "Argument[0]", "hasher-input", "manual"] | ||
| - ["<_ as digest::digest::Digest>::new_with_prefix::digest", "Argument[0]", "hasher-input", "manual"] |
There was a problem hiding this comment.
This doesn't look right. Should it be as follows?
| - ["<_ as digest::digest::Digest>::new_with_prefix::new_with_prefix", "Argument[0]", "hasher-input", "manual"] | |
| - ["<_ as digest::digest::Digest>::new_with_prefix::update", "Argument[0]", "hasher-input", "manual"] | |
| - ["<_ as digest::digest::Digest>::new_with_prefix::chain_update", "Argument[0]", "hasher-input", "manual"] | |
| - ["<_ as digest::digest::Digest>::new_with_prefix::digest", "Argument[0]", "hasher-input", "manual"] | |
| - ["<_ as digest::digest::Digest>::new_with_prefix", "Argument[0]", "hasher-input", "manual"] | |
| - ["<_ as digest::digest::Digest>::update", "Argument[0]", "hasher-input", "manual"] | |
| - ["<_ as digest::digest::Digest>::chain_update", "Argument[0]", "hasher-input", "manual"] | |
| - ["<_ as digest::digest::Digest>::digest", "Argument[0]", "hasher-input", "manual"] |
Update some more legacy MaD models to the new model format (continues from #19934 , but should be independent of that).