Skip to content

Rust: path resolution: handle items in extern blocks #19988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2025
Merged

Rust: path resolution: handle items in extern blocks #19988

merged 3 commits into from
Jul 7, 2025
+18 −45

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Jul 7, 2025

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Jul 7, 2025
@aibaars aibaars force-pushed the aibaars/extern-blocks branch from 202a271 to a8a316f Compare July 7, 2025 12:04
aibaars added 3 commits July 7, 2025 18:02
@aibaars
Rust: add test with extern block
7556d7b
@aibaars
Rust: remove MacroCallItemNode
da2f0f6 
Macro calls are not really items, so they can just be skipped
@aibaars
Rust: use getADescendant instead of getAnItem
7721d14 
This should handle all cases where items contained in intermediate nodes, such as MacroCall,
ExternBlock and MacroItem nodes.
@aibaars aibaars changed the title Rust: path resolution: handle Rust: path resolution: handle items in extern blocks Jul 7, 2025
@aibaars aibaars force-pushed the aibaars/extern-blocks branch from 9025264 to 7721d14 Compare July 7, 2025 16:05
@aibaars aibaars marked this pull request as ready for review July 7, 2025 16:06
@Copilot Copilot AI review requested due to automatic review settings July 7, 2025 16:06
@aibaars aibaars requested a review from a team as a code owner July 7, 2025 16:06
@aibaars aibaars mentioned this pull request Jul 7, 2025
Draft
Copilot
Copilot AI reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@aibaars aibaars added the no-change-note-required This PR does not need a change note label Jul 7, 2025
geoffw0
geoffw0 approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM (discussed on Slack).

DCA LGTM.

I've confirmed that it fixes at least one instance of the problem I had hit.

@aibaars aibaars merged commit aef357c into main Jul 7, 2025
21 of 22 checks passed
@aibaars aibaars deleted the aibaars/extern-blocks branch July 7, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aibaars @geoffw0