Rust: Add type inference inline expectations for all function calls #19993
+2,695
−2,680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/type-inference-function-call-expectations
branch
from
c59d15e to
fad5e0d
Compare
aibaars
reviewed
Jul 7, 2025
| @@ -15,3 +15,6 @@ import codeql.rust.elements.AsyncBlockExpr | |||
| import codeql.rust.elements.Variable | |||
| import codeql.rust.elements.NamedFormatArgument | |||
| import codeql.rust.elements.PositionalFormatArgument | |||
| private import codeql.rust.elements.Call as Call | |||
There was a problem hiding this comment.
Why not simply
import codeql.rust.elements.Call?
There was a problem hiding this comment.
It also exposes the class ArgumentPosition, which I'm not sure we want to.
There was a problem hiding this comment.
Ok makes sense. Perhaps ArgumentPosition should have been in another file.
| fn call_trait_m1<T1, T2: MyTrait<T1>>(x: T2) -> T1 { | ||
| x.m1() // $ method=m1 type=x.m1():T1 | ||
| } | ||
|
|
||
| // Type parameter with bound occurs nested within another type. | ||
|
|
There was a problem hiding this comment.
Let's not shift line numbers for no good reason
Suggested change
There was a problem hiding this comment.
These linebreaks are actually all deliberate; otherwise the comments are treated as identifiers for the proceeding methods, and that breaks inline expectations.
There was a problem hiding this comment.
Ah ok, it looked like a formatter gone wrong.
aibaars
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds inline expectations for all kinds of calls, not just calls to methods.