fix(source/service): disable node informer when not required #5613
+270
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do ?
--service-type-filter
is configured, disable node informer when not requirednodeInformer
used in 2 placesv1.ServiceTypeNodePort
(could be safely disabled)V1. ServiceTypeClusterIP
-> added null check, and warning message, so that if informer is disabled but should be enabledMotivation
Fixes #3169
Follow-up:
--service-type-filter
is specified. This should increase performance and reduce number of API calls and etc.More