Skip to content

fix(source/service): disable node informer when not required #5613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Jul 4, 2025

What does it do ?

  • when --service-type-filter is configured, disable node informer when not required

nodeInformer used in 2 places

  • v1.ServiceTypeNodePort (could be safely disabled)
    • extractNodePortTargets
    • nodesExternalTrafficPolicyTypeLocal
  • V1. ServiceTypeClusterIP -> added null check, and warning message, so that if informer is disabled but should be enabled
    • extractHeadlessEndpoints

Motivation

Fixes #3169

Follow-up:

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 4, 2025
@k8s-ci-robot k8s-ci-robot requested review from mloiseleur and szuecs July 4, 2025 21:19
@k8s-ci-robot k8s-ci-robot added source size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2025
…s activated

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

fix(source/service): disable node informer when service type filter is activated

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

fix(source/service): disable node informer when service type filter is activated

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

fix(source/service): disable node informer when service type filter is activated

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk ivankatliarchuk force-pushed the feat-disable-node-informer-service-3169 branch from 8fda513 to f1dd912 Compare July 4, 2025 21:31
@ivankatliarchuk
Copy link
Contributor Author

Hi @iameli. Not sure if you still interested in the fix. But if yes, can you confirm that this PR fixes your issue. If needed, see how to test a PR ?. This will require golang to be installed.

…s activated

Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
…s activated

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to sync *v1.Node (but I didn't request --source=node)
3 participants