#2298 change yaml parser to a maintained one

[Mivr]

Hello,

I did some work on changing the parser to goccy yaml instead of the unmaintained one, tests are passing and it seems to be working.

Do have in mind that goccy yaml does not preserve the order of fields, so this we can either fix in yq or consider a breaking change.

The current implementation is behind a flag so to not break users.

Note: I am a somewhat skilled go developer, but I haven't touched in years. Most of the code in this PR is generated with AI and then manually checked by me.

Fixes: #2298

[ccoVeille]

I would say it's urgent to wait for the fork that the YAML organization is now officially supporting

https://github.com/yaml/go-yaml

[Mivr]

Oh, in that case, maybe a PR to remove goccy intial integration and use the new fork is relevant? (of course once the package is published)

And maybe I will make a PR to them for the case of "?" handling in go-yaml.

[ccoVeille]

Here,I would let a maintainer reply

But I wanted to raise to anyone attention that yaml/go-yaml exists

[mikefarah]

Good to see that go-yaml is getting support again - will be interesting to see how much activity it gets and how many issues they fix over the next couple of months.

I'm not too sure on this PR - I'm currently working on the goccy decoder/encoder (albeit slowly because life 😅 ) would be good to get it done; but there's a lot of code here I'll need to work through.

Not sure about your comment of not preserving order - that would definitely be a deal breaker; but as far as I can tell it does preserve order.

Nonetheless, I'll be going on an extended holiday soon; will look at this (and progression of go-yaml) when I get back. Till then I won't be making fundamental changes or decisions on yq :)

[mikefarah]

Btw - to really know if the decoding/encoding work properly, you'll need to change the default encoder and decoder in operator.test (e.g. https://github.com/mikefarah/yq/blob/master/pkg/yqlib/operators_test.go#L56) to see if goccy can handle all the various scenarios

[Mivr]

I see that go-yaml might have a version soon, so maybe keeping Goccy behind a flag is a good maybe short term solution as this will unblock some other issues like this one: aspect-build/rules_js#2100

[Mivr]

@mikefarah I think I fixed most of it, a lot of tests had to be ignored, do say what you prefer to do with the different parsing in goccy, for now its just an ignore but I can expect a better approach is needed

[mikefarah]

Having tests ignored will produce more problems than it will solve

[mikefarah]

Oh you've just updated the test expactation to match what the AI code generated :( Sorry but this is never going to work like that.

[Mivr]

Hey @mikefarah I saw your changes in the main branch, and I see you are working on the goccy integration.

I also noticed you have a different approach to some of the things there. That is good and I am willing to work with your approach.

I opened a draft PR: #2392

I would be happy on more feedback on this, at the moment there are about 18 cases where the parsing is not working as before. I will prepare a decent explanation on why and offer some options in the other pr.

The feedback from your last comment is addressed and no tests are changed, some had to be ignore, more on that in the other PR.

My goal is to make this work properly and I will be fixing any errors from the AI or mine. As I mentioned I am a decent developer, haven't written much golang in the last 7 years but I do have very solid foundations in about 11 languages.

My situation is that I am working on other projects that use yq, thus for me now it is a priority to fix yq parsing or replace it in the upstream projects. I hope we can work on this change with you and get it done sooner and with a quality you will be happy with.