-
Notifications
You must be signed in to change notification settings - Fork 973
Rework how we release to central #14146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -16,6 +20,12 @@ plugins { | |||
id("org.graalvm.buildtools.native") apply false | |||
} | |||
|
|||
buildscript { | |||
dependencies { | |||
classpath("com.squareup.okhttp3:okhttp:4.12.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initially wanted to use jdk http client but doing the multipart upload there seemed too hard
|
||
var query = "?name=opentelemetry-java-instrumentation-$stableVersion" | ||
// uncomment to automatically publish the release | ||
// query += "&publishingType=AUTOMATIC" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this parameter we need to publish the uploaded bundled manually. After first successful release we can uncomment it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could become a new gradle plugin 😄
Since the last release with OSSRH Staging API didn't go well we need an alternative way for future releases. We could either adopt JReleaser or one of the plugins from https://central.sonatype.org/publish/publish-portal-gradle/#alternatives or build our own solution.
To publish to central we first publish to a local maven repository named
ReleaseRepo
usingpublishAllPublicationToReleaseRepoRepository
then we zip that repository usinggenerateReleaseBundle
(these 2 were tested when fixing the 2.17.0 release) and finally upload it withuploadReleaseBundle
(this one is untested). We could test by failing the build at the end ofuploadReleaseBundle
and check whether the uploaded bundle is valid in the publisher portal.