Skip to content

fix(deps): update errorproneversion to v2.39.0 #7448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 12, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 25, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.errorprone:error_prone_test_helpers (source) 2.38.0 -> 2.39.0 age adoption passing confidence
com.google.errorprone:error_prone_core (source) 2.38.0 -> 2.39.0 age adoption passing confidence
com.google.errorprone:error_prone_annotations (source) 2.38.0 -> 2.39.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

google/error-prone (com.google.errorprone:error_prone_test_helpers)

v2.39.0: Error Prone 2.39.0

Changes:

  • Temporarily downgrade to Guava 33.4.0 (#​5108)

Checks:

  • BooleanLiteral: Prefer true to Boolean.TRUE
  • ExpensiveLenientFormatString: Renamed from PreconditionsExpensiveString, detects unnecessary calls to String.format in the arguments of lenient formatting methods.
  • UnnecessaryQualifier: Detects @Qualifier or @BindingAnnotation annotations that have no effect, and can be removed

Issues: #​4996, #​5045

Full changelog: google/error-prone@v2.38.0...v2.39.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner June 25, 2025 04:14
@renovate renovate bot force-pushed the renovate/errorproneversion branch from f17ed05 to 9914851 Compare June 30, 2025 17:26
Copy link

codecov bot commented Jul 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.99%. Comparing base (360897b) to head (d1dfae1).
Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7448      +/-   ##
============================================
+ Coverage     89.82%   89.99%   +0.17%     
- Complexity     6998     7077      +79     
============================================
  Files           798      803       +5     
  Lines         21199    21405     +206     
  Branches       2055     2086      +31     
============================================
+ Hits          19041    19264     +223     
+ Misses         1496     1477      -19     
- Partials        662      664       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jkwatson
Copy link
Contributor

jkwatson commented Jul 5, 2025

@jack-berg I think the changes suggested by errorprone here are fine. I'm not in love with the conversion to a builder for the OkHttpGrpcSender, but I also think it's a fine change, since it's not in the hot path of anything. Feel free to veto any changes here you think are not good ones.

Copy link
Contributor Author

renovate bot commented Jul 5, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

return this;
}

public OkHttpGrpcSender<T> createOkHttpGrpcSender() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public OkHttpGrpcSender<T> createOkHttpGrpcSender() {
public OkHttpGrpcSender<T> build() {

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I did mention that I think the action method on the builder should be spelled build() but otherwise seems good.

@jkwatson jkwatson merged commit 804d5f3 into main Jul 12, 2025
30 checks passed
@jkwatson jkwatson deleted the renovate/errorproneversion branch July 12, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants