-
Notifications
You must be signed in to change notification settings - Fork 900
fix(deps): update errorproneversion to v2.39.0 #7448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f17ed05
to
9914851
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7448 +/- ##
============================================
+ Coverage 89.82% 89.99% +0.17%
- Complexity 6998 7077 +79
============================================
Files 798 803 +5
Lines 21199 21405 +206
Branches 2055 2086 +31
============================================
+ Hits 19041 19264 +223
+ Misses 1496 1477 -19
- Partials 662 664 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@jack-berg I think the changes suggested by errorprone here are fine. I'm not in love with the conversion to a builder for the OkHttpGrpcSender, but I also think it's a fine change, since it's not in the hot path of anything. Feel free to veto any changes here you think are not good ones. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
return this; | ||
} | ||
|
||
public OkHttpGrpcSender<T> createOkHttpGrpcSender() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public OkHttpGrpcSender<T> createOkHttpGrpcSender() { | |
public OkHttpGrpcSender<T> build() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I did mention that I think the action method on the builder should be spelled build()
but otherwise seems good.
… by errorprone" This reverts commit febb64e.
This PR contains the following updates:
2.38.0
->2.39.0
2.38.0
->2.39.0
2.38.0
->2.39.0
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
google/error-prone (com.google.errorprone:error_prone_test_helpers)
v2.39.0
: Error Prone 2.39.0Changes:
Checks:
BooleanLiteral
: Prefertrue
toBoolean.TRUE
ExpensiveLenientFormatString
: Renamed fromPreconditionsExpensiveString
, detects unnecessary calls toString.format
in the arguments of lenient formatting methods.UnnecessaryQualifier
: Detects@Qualifier
or@BindingAnnotation
annotations that have no effect, and can be removedIssues: #4996, #5045
Full changelog: google/error-prone@v2.38.0...v2.39.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.