Simplified Gitlab Enumeration #4283
Conversation
|
I performed the following testing after making the changes:
When scanning, all three projects were correctly listed, confirming that the scan includes public, group-based, and standalone private repositories. If there's any other scenario you'd like me to test, please feel free to let me know. |
kashifkhan0771
requested review from
ahrav,
rosecodym and
abmussani
and removed request for
a team
kashifkhan0771
force-pushed
the
update/oss-243
branch
from
51b3bfc to
162ccc8
Compare
kashifkhan0771
force-pushed
the
update/oss-243
branch
from
e0b3ba6 to
20a6bce
Compare
pkg/sources/gitlab/gitlab.go
Outdated
| ctx.Logger().Info("starting projects enumeration", | ||
| "list_options", listOpts, | ||
| "all_available", *projectQueryOptions.Membership) | ||
| gitlabGroupsEnumerated.WithLabelValues(s.name).Set(0) |
There was a problem hiding this comment.
Would you mind placing this metric reset next to the other one? I think it would make things a little clearer to the reader.
There was a problem hiding this comment.
That's not necessary, as we're not enumerating groups in the simplified approach. I'll remove it. I must have overlooked this during the simplification process.
kashifkhan0771
force-pushed
the
update/oss-243
branch
from
4329388 to
6743c17
Compare
| // record the projectsWithNamespace for logging. | ||
| var projectsWithNamespace []string |
There was a problem hiding this comment.
If this is only for logging the count, then we can make the memory usage efficient with something like:
var totalProjects int
...
totalProjects++
...
"count", totalProjects
Description:
Currently, theGitLab source enumerates projects via a complicated, multi-stage system of user queries, group queries, and deduplication. This PR simplify the approach by using
list-all-projectsAPI Call.Checklist:
make test-community)?make lintthis requires golangci-lint)?